Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logs folder #2429

Closed
4 tasks
Tracked by #2205
antonymilne opened this issue Mar 16, 2023 · 0 comments · Fixed by kedro-org/kedro-starters#124
Closed
4 tasks
Tracked by #2205

Remove logs folder #2429

antonymilne opened this issue Mar 16, 2023 · 0 comments · Fixed by kedro-org/kedro-starters#124
Assignees
@ankatiyar
Milestone
Tweak logging to ...

Comments

@antonymilne
Copy link
Contributor

antonymilne commented Mar 16, 2023 •
edited
Loading

Note. Non-breaking, goes in 0.18.x.

Following #2281 and discussions in tech design we are going to simplify the project template by removing the logs folder and errors.log. File-based logging will remain but just be level INFO and above and go to project root instead.

Across all starters the following changes are needed:

  • Change info_file_handler to point to info.log (currently it's configured as filename: logs/info.log)
  • Remove error_file_handler everywhere (including in docs)
  • Delete logs folder
  • Update .gitignore to make sure that *.log gets ignored
This was referenced Mar 16, 2023
Closed
Closed
Closed
@merelcht merelcht moved this to To Do in Kedro Framework Mar 16, 2023
@ankatiyar ankatiyar self-assigned this Apr 20, 2023
@ankatiyar ankatiyar moved this from To Do to In Progress in Kedro Framework Apr 20, 2023
This was referenced Apr 20, 2023
Merged
Merged
@ankatiyar ankatiyar moved this from In Progress to In Review in Kedro Framework Apr 20, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankatiyar ankatiyar

Labels
None yet
Projects
Kedro Framework
Archived in project
Milestone
Tweak logging to improve UX
Development

Successfully merging a pull request may close this issue.

Remove logs folder from kedro-starters kedro-org/kedro-starters
3 participants
@antonymilne @SajidAlamQB @ankatiyar