Draft PR for issue 1946 - Snowpark dataset #2032
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated snowpark test prerequisites Draft implementation of ShowParkDataSet class
|
Also as the PR description at the top says, we'll actually have to move all of this to the new kedro-dataset standalone package. |
datajoely
requested changes
Nov 17, 2022
|
|
||
| missing_module = res[0] | ||
|
|
||
| if KNOWN_PIP_INSTALL.get(missing_module): |
There was a problem hiding this comment.
So the existing way to do this is to edit setup.py and provide optional dependencies.
| return DataSetError(f"{DRIVER_ERROR_MESSAGE}{missing_module_instruction}") | ||
|
|
||
|
|
||
| class SnowflakeTableDataSet(AbstractDataSet[pd.DataFrame, pd.DataFrame]): |
There was a problem hiding this comment.
Suggested change
| class SnowflakeTableDataSet(AbstractDataSet[pd.DataFrame, pd.DataFrame]): | |
| class SnowparkTableDataSet(AbstractDataSet[pd.DataFrame, pd.DataFrame]): |
5 tasks
|
Hi, I am a Field CTO for Datascience at Snowflake and really like the idea of having an integration with Snowpark. You did an amazing job so far and I am happy to support where I can. |
|
@sfc-gh-mgorkow delighted to see you here! Keen to make some noise about this once it launches :) |
|
Development of snowpark integration moved to this PR: kedro-org/kedro-plugins#78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresing comments from previous draft PR
Development notes
Draft implementation of SnowParkDataSet kedro/extras/datasets/snowflake/snowpark_dataset.py
Checklist
RELEASE.mdfile