Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pytest to 7.2 #2278

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Bump pytest to 7.2 #2278

merged 3 commits into from
Feb 3, 2023

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Feb 3, 2023

Signed-off-by: Merel Theisen merel.theisen@quantumblack.com

Description

When running tests locally I saw the message:

DeprecationWarning: You're using an outdated version of pytest. Newer releases of pytest-asyncio will not be compatible with this pytest version. Please update pytest to version 7 or later.

Development notes

Bumped the pytest version in test_requirements to 7.2

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

merelcht and others added 3 commits February 3, 2023 16:06
@merelcht
Bump pytest to 7.2
659f049 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht
Fix broken link
55e52a7 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht
Merge branch 'main' into bump-pytest
1033ffc
@merelcht merelcht marked this pull request as ready for review February 3, 2023 16:51
@merelcht merelcht self-assigned this Feb 3, 2023
@merelcht merelcht requested review from astrojuanlu and SajidAlamQB and removed request for idanov and yetudada February 3, 2023 16:52
astrojuanlu
astrojuanlu approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@merelcht merelcht merged commit 389c101 into main Feb 3, 2023
@merelcht merelcht deleted the bump-pytest branch February 3, 2023 17:04
This was referenced Feb 3, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrojuanlu astrojuanlu astrojuanlu approved these changes

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

Assignees

@merelcht merelcht

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@merelcht @astrojuanlu @SajidAlamQB