-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugging setup of VS Code section update #3181
Conversation
RTD failure seems unrelated: https://beta.readthedocs.org/projects/kedro/builds/22239120/#206508356--366 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR @mustious! I left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instructions look OK to me! Paging @stichbury for the final review
The DCO bot is failing because commit authorship email does not match signoff email, @mustious do you mind having a look at that? You did right by signing off the commits with |
Yes very true. I was using a QB email in my git and a personal email in signing-off. I will make the necessary changes. Thank you @astrojuanlu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes noted in comment on the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @mustious ! 🌟
(I'm meeting with @mustious next week to see if we can understand what's going on with the signoff 😄) |
Signed-off-by: Mustapha Abdullahi <mustious@gmail.com> Signed-off-by: Mustapha Abdullahi <mustapha.abdullahi@quantumblack.com>
Thanks so much @astrojuanlu for your assistance 🚀🎉 |
RTD problem is unrelated:
We will fix it separately |
Signed-off-by: Mustapha Abdullahi <37770012+mustious@users.noreply.github.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Mustapha Abdullahi <mustious@gmail.com> Signed-off-by: Mustapha Abdullahi <mustapha.abdullahi@quantumblack.com> Signed-off-by: Adam Kells <adamjkells93@gmail.com>
Signed-off-by: Mustapha Abdullahi mustious@gmail.com
Description
The earlier documentation will give some users difficulty in setting up VS Code debugging with Kedro as there has been changes in VS Code UI. This PR provides a more descriptive guide to the users in setting up debugging. Following this commit (focused on the debugging), more updates will be made on the overall Kedro with VS Code setup documentation to reflect changes of VS Code UI.
Development notes
Only documentation markdown changed.
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file