Update create_a_pipeline.md #3213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typo: --nodes=preprocess_shuttles_node needs to be specified Signed-off-by: Pranav Dave <75449103+pdave34@users.noreply.github.com>
pdave34
requested review from
yetudada,
astrojuanlu and
stichbury
as code owners
astrojuanlu
requested changes
Oct 21, 2023
Signed-off-by: Juan Luis Cano Rodríguez <hello@juanlu.space>
stichbury
reviewed
Oct 30, 2023
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
|
I've decided to accept this suggested change with some minor modification, which I've committed to the branch. Hope it's all OK and thanks @pdave34 for your contribution! ⭐ |
stichbury
approved these changes
Nov 6, 2023
deepyaman
added a commit
that referenced
this pull request
Nov 8, 2023
* Configure `ruff format`, use it instead of `black` (#3258) * build: format code with `ruff format` over `black` Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * style(ruff-format): format code with `ruff format` Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * docs: fix typos (#3270) Signed-off-by: Ajay Gonepuri <ajaygonepuri@gmail.com> Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com> * Update create_a_pipeline.md (#3213) * Update create_a_pipeline.md typo: --nodes=preprocess_shuttles_node needs to be specified Signed-off-by: Pranav Dave <75449103+pdave34@users.noreply.github.com> * Use both node names Signed-off-by: Juan Luis Cano Rodríguez <hello@juanlu.space> * Update create_a_pipeline.md Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com> --------- Signed-off-by: Pranav Dave <75449103+pdave34@users.noreply.github.com> Signed-off-by: Juan Luis Cano Rodríguez <hello@juanlu.space> Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com> Co-authored-by: Juan Luis Cano Rodríguez <hello@juanlu.space> Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com> * Replace a `StopIteration` exception with for-else (#3273) * Replace a `StopIteration` exception with for-else Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> * fix the logic Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * bug fix Signed-off-by: Nok <nok.lam.chan@quantumblack.com> --------- Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * Make `ruff format` happy Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Make `ruff` happy Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Ajay Gonepuri <ajaygonepuri@gmail.com> Signed-off-by: Pranav Dave <75449103+pdave34@users.noreply.github.com> Signed-off-by: Juan Luis Cano Rodríguez <hello@juanlu.space> Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com> Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> Signed-off-by: Nok <nok.lam.chan@quantumblack.com> Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Co-authored-by: Ajay Gonepuri (GONAPCORP) <98868227+HKABIG@users.noreply.github.com> Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com> Co-authored-by: Pranav Dave <75449103+pdave34@users.noreply.github.com> Co-authored-by: Juan Luis Cano Rodríguez <hello@juanlu.space> Co-authored-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
JaynouOliver
pushed a commit
to JaynouOliver/kedro
that referenced
this pull request
Nov 10, 2023
* Update create_a_pipeline.md typo: --nodes=preprocess_shuttles_node needs to be specified Signed-off-by: Pranav Dave <75449103+pdave34@users.noreply.github.com> * Use both node names Signed-off-by: Juan Luis Cano Rodríguez <hello@juanlu.space> * Update create_a_pipeline.md Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com> --------- Signed-off-by: Pranav Dave <75449103+pdave34@users.noreply.github.com> Signed-off-by: Juan Luis Cano Rodríguez <hello@juanlu.space> Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com> Co-authored-by: Juan Luis Cano Rodríguez <hello@juanlu.space> Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com> Signed-off-by: Suvrakamal Das <jyb2084.usa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typo:
--nodes=preprocess_shuttles_node needs to be specified
Description
To fix a typo in spaceflight documentation
Development notes
Added relevant arguments in the example code
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile