-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove setuptools dependency #3437
Conversation
Failing because of #2350 (comment) |
Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>
4dce074
to
cfdfc11
Compare
@astrojuanlu I saw your proposals: on a first step currently I just emulated setuptools autodiscovery, but maybe it's not a robust solution.
but maybe it's not a mandatory that it must be pyproject.toml file there, and it will not be a check for quantity of packages also. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally look good! 👍 Just left a minor comment. Also don't forget to update the release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic looks correct to me 👍🏽
Indeed @DimedS my other proposals were not completely backwards compatible. And relying on pyproject.toml
isn't either, because of all the transitions in 0.18 (from 1 pyproject.toml + 1 setup.py, to 2 pyproject.toml, to just 1 pyproject.toml)
Hopefully in the future we'll be able to simplify this logic (or even extract the packages directly from the metadata https://discuss.python.org/t/record-the-top-level-names-of-a-wheel-in-metadata/29494/69?u=astrojuanlu)
Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>
Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ⭐
Description
Remove setuptools dependency as mentioned in #2350
Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file