Performance test for OmegaConfigLoader
#4225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
noklam
reviewed
Oct 14, 2024
noklam
reviewed
Oct 14, 2024
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
merelcht
reviewed
Oct 15, 2024
@merelcht Yeah, I had to separate it out into a new class because the |
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
7 tasks
noklam
approved these changes
Oct 15, 2024
ankatiyar
added a commit
that referenced
this pull request
Oct 17, 2024
* first pass doesn't work yet Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update ocl tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * revert some changes Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update to use larger config Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update functions and docstrings Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * lint Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
ankatiyar
added a commit
that referenced
this pull request
Oct 18, 2024
* Update index.md (#4221) Fixed an erroneous link to the Get started with Kedro - Create your first data pipeline with Kedro video. It was accidentally linked to the previous video. Signed-off-by: Greg Vaslowski <7269272+Vaslo@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Bump kedro-sphinx-theme from 2024.4.0 to 2024.10.0 (#4216) * Bump kedro-sphinx-theme from 2024.4.0 to 2024.10.0 Bumps [kedro-sphinx-theme](https://github.com/kedro-org/kedro-sphinx-theme) from 2024.4.0 to 2024.10.0. - [Release notes](https://github.com/kedro-org/kedro-sphinx-theme/releases) - [Commits](kedro-org/kedro-sphinx-theme@v2024.4.0...v2024.10.0) --- updated-dependencies: - dependency-name: kedro-sphinx-theme dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * updated to 2024.10.2 * trigger_run * trigger_run --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Co-authored-by: rashidakanchwala <rashida_kanchwala@mckinsey.com> Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Replace all instances of "data set" with "dataset" (#4211) Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Manually created sitemap.xml for improved control over indexed docs pages (#4145) * Load manually created sitemap Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> * Add projects remove lastmod for latest Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> * Add latest for projects Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> --------- Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> Co-authored-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> Co-authored-by: ElenaKhaustova <157851531+ElenaKhaustova@users.noreply.github.com> Co-authored-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Bump up version to 0.19.9 (#4219) * Bump up version to 0.19.9 Signed-off-by: Laura Couto <laurarccouto@gmail.com> * Add placeholders to release.md Signed-off-by: Laura Couto <laurarccouto@gmail.com> * Update citation.cff release date Signed-off-by: Laura Couto <laurarccouto@gmail.com> --------- Signed-off-by: Laura Couto <laurarccouto@gmail.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * first pass doesn't work yet Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update ocl tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * revert some changes Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update to use larger config Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update functions and docstrings Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Add performance tests for DataCatalog Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update mypy ignore messages (#4228) Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Revise Kedro project structure docs (#4208) * Update project structure docs --------- Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com> Signed-off-by: Dmitry Sorokin <40151847+DimedS@users.noreply.github.com> Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update CLI autocompletion docs with new Click syntax (#4213) * Update CLI autocompletion docs with new Click syntax Updated the autocompletion setup instructions for Bash, Zsh, and Fish shells to reflect the latest Click 8.1 syntax. Changed Fish shell completion script path to ~/.config/fish/completions/kedro.fish for correct placement. Signed-off-by: hyew0nChoi <statistic9935@naver.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Bump import-linter from 2.0 to 2.1 (#4226) Bumps [import-linter](https://github.com/seddonym/import-linter) from 2.0 to 2.1. - [Changelog](https://github.com/seddonym/import-linter/blob/master/CHANGELOG.rst) - [Commits](seddonym/import-linter@v2.0...v2.1) --- updated-dependencies: - dependency-name: import-linter dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Performance test for `OmegaConfigLoader` (#4225) * first pass doesn't work yet Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update ocl tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * revert some changes Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update to use larger config Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update functions and docstrings Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * lint Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Add a test for init and fix indent Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Revert "Add a test for init and fix indent" This reverts commit 0dbe3c7. Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Add a test for init and fix indent Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Greg Vaslowski <7269272+Vaslo@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> Signed-off-by: Laura Couto <laurarccouto@gmail.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com> Signed-off-by: Dmitry Sorokin <40151847+DimedS@users.noreply.github.com> Signed-off-by: hyew0nChoi <statistic9935@naver.com> Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial solution for #4125
Development notes
Added performance test for
OmegaConfigLoaderinbenchmarks/benchmark_ocl.pyfor basic operations for loading catalog, parameters, globalsAs well as another test class for operations with global and custom resolver.
Test locally with
asv runDeveloper Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile