Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_kedro_project_json_data import path #152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jitu5
Copy link
Contributor

@jitu5 jitu5 commented Nov 14, 2024

Descriptions

Resolves #143

This pull request includes a change to the bundled/tool/lsp_server.py file to improve compatibility with different versions of kedro-viz. The most important change is the addition of a try-except block to handle imports for kedro-viz versions greater than and equal to 10.0.0.

Developer Note

  • bundled/tool/lsp_server.py: Added a try-except block to import get_kedro_project_json_data from the correct module based on the kedro-viz version.

Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
@jitu5 jitu5 self-assigned this Nov 14, 2024
@jitu5 jitu5 added Kedro-Viz Functionality/Fix needs to done from Kedro-Viz dependencies Pull requests that update a dependency file labels Nov 14, 2024
@jitu5 jitu5 marked this pull request as ready for review November 14, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Kedro-Viz Functionality/Fix needs to done from Kedro-Viz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update import path for get_kedro_project_json_data
1 participant