Update hardhat version and fix unit tests #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszslabon
force-pushed
the
update-hardhat
branch
from
e1f6ef7
to
90da984
Compare
pdyraga
reviewed
Aug 24, 2021
test/system/liquidation.test.js
Outdated
| @@ -180,7 +181,7 @@ describeFn("System -- liquidation", () => { | |||
| await expect(parseInt(tx.gasLimit)).to.be.lessThan(518000) | |||
|
|
|||
| const txReceipt = await ethers.provider.getTransactionReceipt(tx.hash) | |||
| await expect(parseInt(txReceipt.gasUsed)).to.be.lessThan(255000) | |||
| await expect(parseInt(txReceipt.gasUsed)).to.be.lessThan(400000) | |||
There was a problem hiding this comment.
I am surprised by this increase. Can we check on a local geth instance what is the cost? It is possible that the Hardhat does not properly refund.
tomaszslabon
force-pushed
the
update-hardhat
branch
from
841db95
to
485913a
Compare
tomaszslabon
force-pushed
the
update-hardhat
branch
from
2dc0315
to
3b4e6fa
Compare
pdyraga
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an error in Hardhat
2.2.0, we decided to update Hardhat version and fix errors in unit and system tests.The errors in tests were caused by functions like
isOpen,takeOffer,earlyClosebeing called on auctions that self destructed (the previously used version of Hardhat seemed to tolerate such calls).This PR contains the following changes:
^2.1.1to^2.2.1(it seemsnpminstalled the newest version -2.6.1)isCodeAt(address)which checks whether an address stores contract code, which seems to be the best way to check if contract self-destructedisCodeAtinstead of callingisOpenfor checking auction self-destruction or relying on revertsNote: Unfortunately, in two system tests a significant increase of gas usage was observed.
Note: The contracts themselves were not modified by this PR.