Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sweep proof SPV maintainer (manual version) #3563

Closed
4 tasks done
pdyraga opened this issue May 15, 2023 · 0 comments
Closed
4 tasks done

Sweep proof SPV maintainer (manual version) #3563

pdyraga opened this issue May 15, 2023 · 0 comments
Assignees
@tomaszslabon
Labels
📟 client
Milestone
v2.0.0-m4

Comments

@pdyraga
Copy link
Member

pdyraga commented May 15, 2023 •
edited
Loading

The client can be started in the maintainer mode and manage the Bitcoin difficulty relay. At some point in the future, we want to add the functionality to maintain the wallet lifecycle and submit SPV proofs.

In the short term, we want a CLI command to submit a deposit sweep SPV proof for a wallet transaction. Long-term, we will reuse this code for the maintainer automation.

The CLI command should be simple to use and not require extracting Bitcoin data - all of it should happen under the hood. The intended user of this CLI is the coordinator.

Pull Requests
Beta Give feedback
  1. CLI for submitting deposit sweep proof #3605
    📟 client
    tomaszslabon
  2. MaintainerProxy bindings #3630
    📟 client
    tomaszslabon
  3. MaintainerProxy contract handle #3634
    📟 client
    tomaszslabon
  4. Assemble deposit sweep proof #3571
    📟 client
    tomaszslabon
@pdyraga pdyraga mentioned this issue May 15, 2023
Closed
6 tasks
@tomaszslabon tomaszslabon mentioned this issue May 17, 2023
Merged
@pdyraga pdyraga closed this as completed May 19, 2023
@pdyraga pdyraga reopened this May 19, 2023
@tomaszslabon tomaszslabon mentioned this issue Jun 6, 2023
Merged
@pdyraga pdyraga added this to the v2.0.0-m4 milestone Jun 7, 2023
@pdyraga pdyraga changed the title Sweep proof SPV maintainer Sweep proof SPV maintainer (manual version) Jun 7, 2023
lukasz-zimnoch added a commit that referenced this issue Jun 8, 2023
@lukasz-zimnoch
Assemble deposit sweep proof (#3571)
127429e 
#Refs #3563.

This PR adds functionalities for preparing deposit sweep proof.
These functionalities could also be later used for other types of SPV
proofs.
@pdyraga pdyraga mentioned this issue Jun 20, 2023
Merged
tomaszslabon added a commit that referenced this issue Jun 20, 2023
@tomaszslabon
Add an extra 20% gas to the sweep SPV proof transaction (#3645)
66ea36a 
Refs #3563

The original estimate is too low and the call fails with out of gas
problem when reimbursing the submitter.

This is an example TX submitted with the same data but gas limit
(before/after):

https://etherscan.io/tx/0xe27a92883e0e64da8a3a54a15a260ea2f4d3d48470129ac5c09bfe9637d7e114

https://etherscan.io/tx/0x90a44b4c8cd810c7ec4450e429abfe136fe82fc59d220775ef8838ba0fdc09b8
@pdyraga pdyraga closed this as completed Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomaszslabon tomaszslabon

Labels
📟 client
Projects
None yet
Milestone
v2.0.0-m4
Development

No branches or pull requests
2 participants
@pdyraga @tomaszslabon