Replace the CircleCI build status badge with GHA badges #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalinacienciala
force-pushed
the
rfc-18/replace-circle-status-badge
branch
from
7b5821d
to
aafb458
Compare
We no longer use CircleCI to test/build the `keep-core` code. We need to replace the CircleCI build status badge in the projec'ts README with the similiar badges for GitHub Actions builds. Two badges have been introduced in place of the old one: * Solidity build (showing status of the last `Solidity` workflow executed on `master` branch and triggered by the push event), * Go build (showing status of the last `Go` workflow executed on `master` branch and triggered by the push event). The badges are displayed using `shields.io` tool, which was already used for the Discord badge. Also a badge was added in the README of the Token Dashboard: * Token Dashboard / Testnet (showing status of the last `Token Dashboard / Testnet` workflow on `master` branch and triggered by the push event). This time standard GitHub badge was used, as `shields.io` tool currently does not support workflows with slash character in their name (see badges/shields#4559).
michalinacienciala
force-pushed
the
rfc-18/replace-circle-status-badge
branch
from
aafb458
to
36a232f
Compare
This was referenced Jun 18, 2021
nkuba
approved these changes
Jul 2, 2021
|
I'm merging this PR @michalinacienciala . Please remember to update #2521 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer use CircleCI to test/build the
keep-corecode. We need toreplace the CircleCI build status badge in the projec'ts README with the
similiar badges for GitHub Actions builds.
Two badges have been introduced in place of the old one:
Solidityworkflow executed onmasterbranch and triggered by the push event),Goworkflow executed onmasterbranch and triggered by the push event).The badges are displayed using
shields.iotool, which was already usedfor the Discord badge.
Also a badge was added in the README of the Token Dashboard:
Token Dashboard / Testnetworkflow onmasterbranch and triggered by the push event).This time standard GitHub badge was used, as
shields.iotool currentlydoes not support workflows with slash character in their name (see
badges/shields#4559).
Refs:
keep-network/keep-ecdsa#835
keep-network/tbtc#809