-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] dApp-friendly contract deployment #403
base: main
Are you sure you want to change the base?
Commits on Aug 10, 2022
-
Add a mock fn that register the ECDSA wallet
To create a deposit or request redemption the ECDSA wallet is required. To not involve the off-chain clients here we add a mock function that registers the fake ECDSA wallet in the `Bridge` contract. Anyone can execute this function. In this mocked function we also pass the main utxo params because it is required for redemption flow.
Configuration menu - View commit details
-
Copy full SHA for 7cea4cf - Browse repository at this point
Copy the full SHA 7cea4cfView commit details -
Add hardhat task to create the mocked ECDSA wallet
This task is responsible for registering the ECDSA wallet with mocked data. We need to trigger this task manually to mock the off-chain clients work. This allows us to reveal deposit and request redemption.
Configuration menu - View commit details
-
Copy full SHA for 729627b - Browse repository at this point
Copy the full SHA 729627bView commit details -
Add a mock function that sweeps a deposit
The off-chain clients are responsible for sweeping deposit. We need to create mocked version of this function and we will trigger it manually- we will mock the client work. To simplify the deposit sweep flow this mocked function will take only one deposit. In taht fact we can mock the off-chain clients work and sweep a deposit.
Configuration menu - View commit details
-
Copy full SHA for ce6f476 - Browse repository at this point
Copy the full SHA ce6f476View commit details -
Add hardhat task to sweep a deposit
Running this task we can sweep a deposit- in this way we mock the off-chain clients work.
Configuration menu - View commit details
-
Copy full SHA for 6cab577 - Browse repository at this point
Copy the full SHA 6cab577View commit details -
Add a mock function to submit the redemption proof
The off-chain clients are responsible for this part. We need to mock `submitRedemptionProof` function and we will trigger it manually to mock the off-chain clients work. This function removes the redemption from the `pendingRedemptions` map.
Configuration menu - View commit details
-
Copy full SHA for 4e1a1ee - Browse repository at this point
Copy the full SHA 4e1a1eeView commit details
Commits on Aug 15, 2022
-
Fix a
submitRedemptionProof
taskThe name of the task should be unique.
Configuration menu - View commit details
-
Copy full SHA for 6b1e78e - Browse repository at this point
Copy the full SHA 6b1e78eView commit details
Commits on Aug 16, 2022
-
Update the mocked deposit tx fee
The previous amount was too high and EVM was throwing an error because the deposited amount was `<0`.
Configuration menu - View commit details
-
Copy full SHA for 36e5846 - Browse repository at this point
Copy the full SHA 36e5846View commit details -
Update a hardhat task that creates a mocked wallet
We need to register the wallet in the `WalletRegistry` contract because the tbtc-v2.ts lib calls this contract to get the wallet public key. Please see: https://github.com/keep-network/tbtc-v2/blob/main/typescript/src/ethereum.ts#L392-L395
Configuration menu - View commit details
-
Copy full SHA for cc22813 - Browse repository at this point
Copy the full SHA cc22813View commit details -
Updates the hardhat task that submits the deposit sweep proof- get the depoist by key for the contract and log the `sweptAt` param.
Configuration menu - View commit details
-
Copy full SHA for 3af9b83 - Browse repository at this point
Copy the full SHA 3af9b83View commit details -
Add task that returns the revealed deposits/redemption request events by the `depositor/redeemer` address. This task logs unnecessary parameters to run the task that submits the deposit sweep/redemption proof.
Configuration menu - View commit details
-
Copy full SHA for ad1511c - Browse repository at this point
Copy the full SHA ad1511cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f3e61b - Browse repository at this point
Copy the full SHA 2f3e61bView commit details -
Use kebab case for the name of the hardhat task
To be consistent with the name of parameters auto-generated by hardhat.
Configuration menu - View commit details
-
Copy full SHA for e3c17cc - Browse repository at this point
Copy the full SHA e3c17ccView commit details
Commits on Aug 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8cf4cdc - Browse repository at this point
Copy the full SHA 8cf4cdcView commit details -
Set `dapp-development-goerli` tag for `@keep-network/random-beacon` and `@keep-network/ecdsa`. We need dapp-friendly contracts here.
Configuration menu - View commit details
-
Copy full SHA for 18ce7cb - Browse repository at this point
Copy the full SHA 18ce7cbView commit details
Commits on Sep 1, 2022
-
Change version's suffix to
-dapp-dev-goerli
We are publishing packages with code from `dapp-development` branch under versions that use `-dapp-dev-goerli.X` suffix. Our `package.json` on this branch should reflect that. If we do not set it up, the CI job used to pubblish the package will not be able to correctly bump up the version of the package.
Configuration menu - View commit details
-
Copy full SHA for 7b5e7b6 - Browse repository at this point
Copy the full SHA 7b5e7b6View commit details
Commits on Sep 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2560afc - Browse repository at this point
Copy the full SHA 2560afcView commit details -
Update solidity config for ecdsa
Update number of optimizer runs to reduce the size of the `WalletRegistry` contract. Lower values of runs will optimize more for initial deployment cost(contract size) but the execution costs will be higher. We don't have to worry about the execution cost of `WalletRegistry` contract because changes from `dapp-development` branch are only for testnet networks.
Configuration menu - View commit details
-
Copy full SHA for 144e7ce - Browse repository at this point
Copy the full SHA 144e7ceView commit details -
Commented out these lines because wanted to test local deployment with the dapp-frielndy `Bridge` contract. Should't have pushed these changes to the remote branch.
Configuration menu - View commit details
-
Copy full SHA for 93de579 - Browse repository at this point
Copy the full SHA 93de579View commit details
Commits on Sep 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8d043fe - Browse repository at this point
Copy the full SHA 8d043feView commit details
Commits on Dec 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 607d806 - Browse repository at this point
Copy the full SHA 607d806View commit details
Commits on Jan 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 37494a7 - Browse repository at this point
Copy the full SHA 37494a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a34b17 - Browse repository at this point
Copy the full SHA 9a34b17View commit details
Commits on Jan 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a2c3074 - Browse repository at this point
Copy the full SHA a2c3074View commit details -
Remove
tenderly
tag for goerli networkWe changed the version range for `@tenderly/hardhat-tenderly` in #440 and CI build fails on tenderly verification. Since this is a `dapp-development` branch, we do not actually need the tenderly verification at least for now so here we remove the `tenderly` tag for `goerli` network to skip the tenderly veirification.
Configuration menu - View commit details
-
Copy full SHA for 4450c03 - Browse repository at this point
Copy the full SHA 4450c03View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef7beb7 - Browse repository at this point
Copy the full SHA ef7beb7View commit details
Commits on Jan 12, 2023
-
Add tasks with which you will be able to do an optimistic minting.
Configuration menu - View commit details
-
Copy full SHA for 93773eb - Browse repository at this point
Copy the full SHA 93773ebView commit details
Commits on Jan 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4d3a05d - Browse repository at this point
Copy the full SHA 4d3a05dView commit details -
Set to `120 s` -> `2min` to speed up the optimistic minting QA in T dapp.
Configuration menu - View commit details
-
Copy full SHA for 82a079a - Browse repository at this point
Copy the full SHA 82a079aView commit details -
Remove
tenderly
tag for goerli networkWe changed the version range for `@tenderly/hardhat-tenderly` in #440 and CI build fails on tenderly verification. Since this is a `dapp-development` branch, we do not actually need the tenderly verification at least for now so here we remove the `tenderly` tag for `goerli` network to skip the tenderly veirification.
Configuration menu - View commit details
-
Copy full SHA for 91833bb - Browse repository at this point
Copy the full SHA 91833bbView commit details
Commits on Jan 20, 2023
-
Set
GOVERNANCE_DELAY
inVendingMachine
to0
To QA the optimistic minting in T dapp we need to transfer the ownership of the `TBTC` token contract. The `TBTCVault` should be an owner of the `TBTC` token contract. The only way to do this is via `VendingMachine` contract because is currently set as an owner of `TBTC` token contract in deployment scripts.
Configuration menu - View commit details
-
Copy full SHA for d0e2c3b - Browse repository at this point
Copy the full SHA d0e2c3bView commit details -
Transfer the ownership of the TBTC token contract via `VendingMachine` contract. In omptimistic minting, the `TBTCVault` contract should be the owner of the `TBTC` token contract.
Configuration menu - View commit details
-
Copy full SHA for 51ede5a - Browse repository at this point
Copy the full SHA 51ede5aView commit details
Commits on Jan 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a78a073 - Browse repository at this point
Copy the full SHA a78a073View commit details -
Update `ecdsa` and `random-beacon` package version.
Configuration menu - View commit details
-
Copy full SHA for fe01903 - Browse repository at this point
Copy the full SHA fe01903View commit details -
Remove unnecessary deployment script
We want the TBTCVault to be the owner of the TBTC token and we do it in earlier deployment step. The script `94_*` was a workaround and now it's unnecessary. See #488.
Configuration menu - View commit details
-
Copy full SHA for 65a2cfa - Browse repository at this point
Copy the full SHA 65a2cfaView commit details
Commits on Aug 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a12ca03 - Browse repository at this point
Copy the full SHA a12ca03View commit details -
Update mocked
submitRedemptionProof
fn\Add `redemptionTxHash` param it should be a Bitcoin testnet transaction hash(byte order corresponds to the Bitcoin internal byte order) that was made from a given wallet to a given redeemer output script. Thanks to that we can find the tx on the Bitcoin chain and display data in the dapp.
Configuration menu - View commit details
-
Copy full SHA for bb6f174 - Browse repository at this point
Copy the full SHA bb6f174View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54be0a5 - Browse repository at this point
Copy the full SHA 54be0a5View commit details
Commits on Nov 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 39472bf - Browse repository at this point
Copy the full SHA 39472bfView commit details -
We're switching deployment to the Sepolia testnet due to planned deprecation of the Goerli testnet. In a previous commit we've updated the `dapp-development` branch with the recent changes from `main` (among them were the changes adding Sepolia to the list of supported networks). Now we're updating the `dapp-development` branch to create `dapp-dev-sepolia` packages.
Configuration menu - View commit details
-
Copy full SHA for 7d910df - Browse repository at this point
Copy the full SHA 7d910dfView commit details
Commits on Mar 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5b29ae0 - Browse repository at this point
Copy the full SHA 5b29ae0View commit details -
Move documentation to separate file
Move documentation from Pull Request description to a separate .adoc file. This way we can keep track of changed.
Configuration menu - View commit details
-
Copy full SHA for 9220c50 - Browse repository at this point
Copy the full SHA 9220c50View commit details