Fix Bridge contract artifact for Sepolia
#811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While fetching contract events, the start block for the searched range is taken based on the contract creation block. This is the `receipt.blockNumber` field living in the contract artifact. However, this field may be overwritten by the Hardhat Upgrades plugin and point to the deployment block of the recent contract implementation, not the transparent proxy. This was the case for the Sepolia `Bridge` artifact. Contract events like `NewWalletRegistered` were taken starting from the recent implementation deployment block which occurred much later than the `Bridge` proxy deployment. In effect, it was not possible to fetch all `Bridge` wallets ever created. Here we fix that problem.
lukasz-zimnoch
added
🐛 bug
michalinacienciala
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fetching contract events, the start block for the searched range is taken based on the contract creation block. This is the
receipt.blockNumberfield living in the contract artifact. However, this field may be overwritten by the Hardhat Upgrades plugin and point to the deployment block of the recent contract implementation, not the transparent proxy.This was the case for the Sepolia
Bridgeartifact. Contract events likeNewWalletRegisteredwere taken starting from the recent implementation deployment block which occurred much later than theBridgeproxy deployment. In effect, it was not possible to fetch allBridgewallets ever created.Here we fix that problem.