SDK: Expose a way to fetch pending redemptions using wallet PKH #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, the SDK exposed a way to fetch pending redemptions using plain-text wallet public key. This is problematic for use cases where the client has only the wallet public key hash. As the SDK uses the PKH internally anyway, we can easily address this problem by exposing a public function allowing to fetch pending redemptions using wallet PKH.
tomaszslabon
approved these changes
Jul 5, 2024
tomaszslabon
added a commit
that referenced
this pull request
Jul 5, 2024
Depends on: #818 Depends on: #820 Here we migrate the monitoring package to the latest version of tBTC SDK. We are using the latest `development` version of the SDK for now as it contains some unreleased features and fixes that are useful for the monitoring tool. Migration of the monitoring to the new tBTC SDK pays off some tech debt but also reduces the number of requests sent to the Ethereum node due to some optimizations introduced in the recent versions of the SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the SDK exposed a way to fetch pending redemptions using plain-text wallet public key. This is problematic for use cases where the client has only the wallet public key hash. As the SDK uses the PKH internally anyway, we can easily address this problem by exposing a public function allowing to fetch pending redemptions using wallet PKH.