This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Touchups #13
Merged
Touchups #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadowfiend
reviewed
Mar 26, 2020
| */ | ||
| async getSignerFee() { | ||
| return toBN(await this.contract.methods.signerFee().call()) | ||
| } |
Shadowfiend
reviewed
Mar 26, 2020
src/Deposit.js
Outdated
| * Get the signer fee, to be paid at redemption. | ||
| * @return {Promise<BN>} A promise to the signer fee for this deposit, in TBTC. | ||
| */ | ||
| async getSignerFee() { |
There was a problem hiding this comment.
Although please include the unit in this method name, now that I think about it (getSatoshiSignerFee or similar).
There was a problem hiding this comment.
Almost Hungarian. 😉
Observation - the naming styles are a bit diverse across the board, we seem to prefer lowercase Tbtc for getters, and uppercase for minting.
- getSatoshiLotSize
- getSignerFee
- lotSizeTbtc
- auctionTBTCAmount
It's clearer to denominate the fee in the method name itself.
Shadowfiend
approved these changes
Mar 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
getSignerFeehelper to Deposit.This line in tbtc-dapp fails with the new web3 tbtc.js. The new method call would be deposit.methods.signerFee().call(), although the line above uses a helper - I figure we should use one here too.
Convert redemptionCost BN to string
I found this while investigating our Discord bug. I didn't test this less-travelled code path of redemption.