Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Disabled publishing of contract artifacts and maintainers container to keep-dev #318

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

pdyraga
Copy link
Member

@pdyraga pdyraga commented Oct 9, 2019

It's a temporary change for the purpose of having a stable demo environment. We'll bring it back later when we figure out how to version-tag our deployments properly.

It's a temporary change for the purpose of having a stable demo
environment. We'll bring it back later when we figure out how to
version-tag our deployments properly.
context: keep-dev
requires:
- migrate_contracts
# - build_initcontainer:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure you did this to save time, to be clear it's not strictly required....makes sense from a time saving perspective while we're not publishing though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that was my reasoning sir.

@sthompson22
Copy link
Contributor

Mmmm do we need the migrate_contracts step at this point? I think we can just skip it all together since we'll be leaning on the contracts included in the last published artifacts.

@pdyraga
Copy link
Member Author

pdyraga commented Oct 9, 2019

Mmmm do we need the migrate_contracts step at this point? I think we can just skip it all together since we'll be leaning on the contracts included in the last published artifacts.

You are right, though... in the Uniswap deployment PR we discovered some problems on CI during contract deployment after we merged that PR. I think it makes sense to leave this job running just to make sure we don't break something and discover it one month later.

@sthompson22 sthompson22 merged commit 7087732 into master Oct 9, 2019
@sthompson22 sthompson22 deleted the disable-deploy branch October 9, 2019 18:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants