Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Two-step change for governable values #515

Merged
merged 17 commits into from
Mar 16, 2020
Merged

Two-step change for governable values #515

merged 17 commits into from
Mar 16, 2020

Commits on Mar 5, 2020

  1. Time delay Governable value changes 

    The time delay ensures that users have more information regarding the
state of the contract.
This is to avoid situatoins where the state of a Deposit is
unpredictable due to governance changes earlier within the same block.
    NicholasDotSol committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    eb7328a View commit details
    Browse the repository at this point in the history

  2. Test governable value time delay

    NicholasDotSol committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    3375a2a View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2020

  1. Extract delay check to a modifier

    NicholasDotSol committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    b0b8b5f View commit details
    Browse the repository at this point in the history

  2. Update system tests 

    Uninitiated change and unelapsed timer are separate test cases now.
    NicholasDotSol committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    7e64610 View commit details
    Browse the repository at this point in the history

  3. Check values after update finalization 

    Ensure the values are changes correctly
    NicholasDotSol committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    bce465c View commit details
    Browse the repository at this point in the history

  4. Extract common getRemainingUpdateTerm functionality 

    getRemainingUpdateTime functions share most of their functinality.
Extract that functionality into an internal function.
    NicholasDotSol committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    e5cd842 View commit details
    Browse the repository at this point in the history

  5. test getRemainingUpdateTime functions

    NicholasDotSol committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    d7adb82 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into two-step-gov

    @NicholasDotSol
    NicholasDotSol authored Mar 6, 2020
    Configuration menu
    Copy the full SHA
    2c9c262 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. Test Value update init override 

    Ensure the update overrides the old value and resets the timestamp.
Time tests have a grac eperiod of 1 second to account for
unexpected time incrememnts due due to computation time.
    NicholasDotSol committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    596088b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into two-step-gov

    @NicholasDotSol
    NicholasDotSol authored Mar 10, 2020
    Configuration menu
    Copy the full SHA
    eeba9fb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into two-step-gov

    @NicholasDotSol
    NicholasDotSol authored Mar 10, 2020
    Configuration menu
    Copy the full SHA
    7690419 View commit details
    Browse the repository at this point in the history

  4. governanceTimeDelay Update 

    From 1 hour to 6
    NicholasDotSol committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    3e8687e View commit details
    Browse the repository at this point in the history

  5. Add grace of 1 block to timestamp check 

    Adding the timestamp grace
allows the test to be off by 1
due to execution time pushing the timestamp up by 1 unpredictably
    NicholasDotSol committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    bdb417d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'two-step-gov' of https://github.com/keep-network/tbtc i… 

    …nto two-step-gov
    NicholasDotSol committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    cfdc916 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. Merge branch 'master' into two-step-gov

    @NicholasDotSol
    NicholasDotSol authored Mar 12, 2020
    Configuration menu
    Copy the full SHA
    864c2db View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2020

  1. Merge branch 'master' into two-step-gov

    @nkuba
    nkuba authored Mar 16, 2020
    Configuration menu
    Copy the full SHA
    45171be View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into two-step-gov

    @Shadowfiend
    Shadowfiend authored Mar 16, 2020
    Configuration menu
    Copy the full SHA
    d65592b View commit details
    Browse the repository at this point in the history