This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Exit undercollateralized liquidation #529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 16, 2020 23:22
To be called when we exit undercollateralized liquidation state
add an extra state specifically to keep track of liquidation due to undercollateralization. This is needed since this liquidation state that can be exited via exitUndercollateralizedLiquidation
Allow for the ability to exit liquidation state if the signer bond values recovers before liquidation occurs.
In case of a flash-crash, a lower base percentage means there is more time for price recovery.
|
@NicholasDotSol let's pull ee4cf3e out to its own PR so we can merge it. Still not convinced I want the rest of this, but I also don't want to close the PR yet… Just need to think about it some more, and don't want to block the liquidation percentage change. |
|
Commit in question was pulled out to #539. Holding on this PR for now. |
|
I'm going to close this PR without deleting the branch. We may revisit, but at this point it's highly unlikely this'll land before mainnet. We can reconsider this possibility for v2, however. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #494
given an oracle price slip flash crash event, someone can initiate undercollateralized liquidation. This PR introduces a way to exit this liquidation flow back to the
Activestate.UNDERCOLLATERALIZED_LIQUIDATION_IN_PROGRESS. exiting the liquidation state can only happen from this new state. Liquidation should not be exited if there a signer abort or fraud.redemptionTeardowngas savings was moved topurchaseSignerBondsAtAuctionto avoid complications while exiting the liquidation state.unresolved: