Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

DepositLog refactor #537

Merged
merged 8 commits into from
Mar 27, 2020
Merged

DepositLog refactor #537

merged 8 commits into from
Mar 27, 2020

Commits on Mar 23, 2020

  1. Remove outdated comment

    No need for the warning, funcion is no longer empty
    NicholasDotSol committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    8a9db61 View commit details
    Browse the repository at this point in the history
  2. Remove tbtcDepositToken from tbtcSystem

    TBTCSystem and DepositLog hold an independent copy of  TBTCDepositToken
    
    TbtcSystem extedns DepositLog and theref ore the variable is shodowed.
    
    Instead of renaming and keeping both, using only the one from
    DepositLog is preferable
    NicholasDotSol committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    8ea92a6 View commit details
    Browse the repository at this point in the history
  3. Remove log return values

    The return values are not used. On approvedToLog error
    revert isntead of returning false.
    Returning false offers the abhlity to not halt the
    deposit if approvedToLog returns false.
    This does not fel like a real perk. if approvedToLog returns
    false the event loger is not the deposit contract, and should revert.
    NicholasDotSol committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    6837b39 View commit details
    Browse the repository at this point in the history
  4. Update tests

    NicholasDotSol committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    7aad202 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    612fbf9 View commit details
    Browse the repository at this point in the history
  6. Make setTbtcDepositToken internal

    setTbtcDepositToken should only be called internally
    NicholasDotSol committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    f1810be View commit details
    Browse the repository at this point in the history
  7. Merge branch 'log-refactor' of https://github.com/keep-network/tbtc i…

    …nto log-refactor
    NicholasDotSol committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    597cdfe View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2020

  1. Merge branch 'master' into log-refactor

    NicholasDotSol committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    53e6030 View commit details
    Browse the repository at this point in the history