This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
Dynamic base liquidation percentage #539
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
da18fbd
Remove AUCTION_BASE_PERCENTAGE constant
6f7c1f6
Implement getAuctionBasePercentage
3b0233b
Expose getInitialCollateralizedPercent for testing
a91a1e3
test getAuctionBasePercentage
1ed77a3
Updates tests
5621289
Track initialCollateralizedPercent
b46d498
Update Tests
8ef9c4b
Merge branch 'master' into base-liq-percent
Shadowfiend File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -383,12 +383,24 @@ describe("DepositUtils", async function() { | |
}) | ||
}) | ||
|
||
describe("getAuctionBasePercentage()", async () => { | ||
it("returns correct base percentage", async () => { | ||
const basePercentage = await testDeposit.getAuctionBasePercentage.call() | ||
|
||
const initialCollateralization = await tbtcSystemStub.getInitialCollateralizedPercent() | ||
|
||
// 10000 to avoid losing value to truncating is solidity. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in? |
||
const expecged = new BN(10000).div(initialCollateralization) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sp |
||
expect(basePercentage).to.eq.BN(expecged) // 66 for 150 | ||
}) | ||
}) | ||
|
||
describe("auctionValue()", async () => { | ||
let duration | ||
let basePercentage | ||
before(async () => { | ||
duration = await tbtcConstants.getAuctionDuration.call() | ||
basePercentage = await tbtcConstants.getAuctionBasePercentage.call() | ||
basePercentage = await testDeposit.getAuctionBasePercentage.call() | ||
auctionValue = new BN(100000000) | ||
}) | ||
beforeEach(async () => { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to store this at deposit creation, otherwise the existing deposit's behavior changes based on governance actions :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
derp.