Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all Option::None(()) to remove (()) #153

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Update all Option::None(()) to remove (()) #153

merged 3 commits into from
Aug 9, 2023

Conversation

gaetbout
Copy link
Collaborator

@gaetbout gaetbout commented Aug 8, 2023

Updated:

  • break (); => break;
  • Option::None(()) => Option::None
  • Option::None(_) => Option::None

@gaetbout gaetbout requested a review from 0xLucqs as a code owner August 8, 2023 12:07
0xLucqs
0xLucqs requested changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@0xLucqs 0xLucqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you get the idea

src/data_structures/tests/stack_test.cairo Show resolved Hide resolved
0xLucqs
0xLucqs requested changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@0xLucqs 0xLucqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est reparti pour un tour

src/data_structures/stack.cairo Show resolved Hide resolved
0xLucqs
0xLucqs approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@0xLucqs 0xLucqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xLucqs 0xLucqs merged commit a573a5e into keep-starknet-strange:main Aug 9, 2023
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@0xLucqs 0xLucqs 0xLucqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaetbout @0xLucqs