Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the
pow
impl to use binary exponentiation, which is cheaper.Please check the type of change your PR introduces:
What is the current behavior?
pow
is O(n)What is the new behavior?
pow
is O(log n)Does this introduce a breaking change?
Other information
I did a simple benchmark. Stepwise performance is the same for a simple case, the greater the exponent the more efficient this new implementation is.
Added a testcase to check for the whole 2^N range.
FWIW, it's pretty much the same as
BitShift::fpow
😁 but without the use of Bitwise ops.