generated from eigerco/beerus
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Merkle tree generation #178
Merged
0xLucqs
merged 14 commits into
keep-starknet-strange:main
from
bal7hazar:feat/merkle-tree-generation
Sep 18, 2023
Merged
✨ Merkle tree generation #178
0xLucqs
merged 14 commits into
keep-starknet-strange:main
from
bal7hazar:feat/merkle-tree-generation
Sep 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add poseidon version of the merkle tree - Add proof computation - Clean and add corresponding tests
gaetbout
reviewed
Sep 8, 2023
@LucasLvy could you take the lead on this review please to move forward? |
0xLucqs
requested changes
Sep 18, 2023
0xLucqs
force-pushed
the
feat/merkle-tree-generation
branch
from
September 18, 2023 13:24
ea3d587
to
fc55f06
Compare
0xLucqs
force-pushed
the
feat/merkle-tree-generation
branch
from
September 18, 2023 14:17
fc55f06
to
b229629
Compare
0xLucqs
requested changes
Sep 18, 2023
Co-authored-by: Lucas @ StarkWare <70894690+LucasLvy@users.noreply.github.com>
0xLucqs
approved these changes
Sep 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #169
Issue Number: #170
What is the new behavior?
compute_proof
method to the MerkleTreeTrait to generate a proof based on leaves and an indexDoes this introduce a breaking change?
Before the change you could just have:
Now you must specify which kind of merkle tree you want (the legacy version or the new one):
Other information
Work load: ~ 8 hours