-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Starknet storage proof verifier #189
feat: Starknet storage proof verifier #189
Conversation
It is not the same thing. merkle_tree.cairo is an implementation of generic Merkle Tree while proof.cairo verifies Starknet storage which use binary Merkle-Patricia Trie. |
It's not the same thing indeed but they are both related to merkle trees, don't you think they should live in the same crate ? |
Are you suggesting to put storage_proof into data_structures crate? |
Hmm I’d rather move the merkle tree out of the data structure crate and create a ˋmerkle_treeˋ crate that would hold the merkle tree and merkle proof |
Why a separate crate? Because they are more complex data structes than queue, stack, vec? |
Because storage proof doesn’t really make sense in data structure and I think that grouping merkle tree and storage proof verification makes sense |
Reorganized code under merkle_tree crate as you suggested. I am not convinced but it is better to try and fix later instead of spending time to discuss it. |
Starknet storage proof verifier.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information