Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fixed infinite loop bug on bubble sort #219

Merged

Conversation

azurwastaken
Copy link
Contributor

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #217

What is the new behavior?

  • Bubble sort don't infinite loop anymore when there is equal values

Does this introduce a breaking change?

  • Yes
  • No

Other information

Also added a test to ensure the problem doesn't happen again

@0xLucqs 0xLucqs merged commit be8a632 into keep-starknet-strange:main Nov 23, 2023
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants