div mod tests #238
Merged
div mod tests #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xLucqs
approved these changes
Jan 12, 2024
0xLucqs
pushed a commit
that referenced
this pull request
Jan 12, 2024
<!--- Please provide a general summary of your changes in the title above --> ## Pull Request type Optimisations for mod arithmetics. Please check the type of change your PR introduces: - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming) - [x] Refactoring (no functional changes, no API changes) - [ ] Build-related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? Mod operations not as fast as they can be. Issue Number: N/A ## What is the new behavior? >⚠️ `div_mod` test included here is added in PR #238 ``` DIVISION OPTIMISATION (from core::math functions) // div_mod_test BEFORE gas usage est.: 97351914 // div_mod_test BEFORE gas usage est.: 277900 MINOR optimisations (from inline) // add_mod_1_test BEFORE gas usage est.: 163180 // add_mod_1_test AFTER gas usage est.: 159880 // add_mod_2_test BEFORE gas usage est.: 109020 // add_mod_2_test AFTER gas usage est.: 106820 // add_mod_p_test BEFORE gas usage est.: 433980 // add_mod_p_test AFTER gas usage est.: 425180 // mult_mod_1_test BEFORE gas usage est.: 455340 // mult_mod_1_test AFTER gas usage est.: 444940 // mult_mod_2_test BEFORE gas usage est.: 455340 // mult_mod_2_test AFTER gas usage est.: 444940 // mult_mod_test BEFORE gas usage est.: 455340 // mult_mod_test AFTER gas usage est.: 444940 // sub_mod_1_test BEFORE gas usage est.: 330380 // sub_mod_1_test AFTER gas usage est.: 319980 // sub_mod_2_test BEFORE gas usage est.: 330380 // sub_mod_2_test AFTER gas usage est.: 319980 // sub_mod_test BEFORE gas usage est.: 356100 // sub_mod_test AFTER gas usage est.: 346300 ``` ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this does introduce a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR, such as screenshots of how the component looks before and after the change. -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic tests for div_mod
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
No div_mod test.
What is the new behavior?
Basic div_mod test added.
Does this introduce a breaking change?
Other information
For 30 / 10 test,