Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add levenshtein distance calculator #260

Merged
merged 2 commits into from
Jan 25, 2024
Merged

feat: add levenshtein distance calculator #260

merged 2 commits into from
Jan 25, 2024

Conversation

Soptq
Copy link
Contributor

@Soptq Soptq commented Jan 24, 2024

This PR adds calculation of the Levenshtein distance of two ByteArray.

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • calculating the Levenshtein distance of two ByteArray.
  • all tests are passed.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@Soptq Soptq requested a review from 0xLucqs as a code owner January 24, 2024 15:17
0xLucqs
0xLucqs reviewed Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@0xLucqs 0xLucqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, add comments and meaningful variable names

src/searching/src/levenshtein_distance.cairo Outdated Show resolved Hide resolved
@0xLucqs 0xLucqs merged commit c2308aa into keep-starknet-strange:main Jan 25, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@0xLucqs 0xLucqs 0xLucqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Soptq @0xLucqs