Upgrade to Cairo 2.5.3 and other refactors

[delaaxe]

Pull Request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build-related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

• Yes
• No

Other information

[0xLucqs]

put #272 and #270 in the same PR as this one

[delaaxe]

Sure El El jue, 1 feb 2024 a la(s) 8:52, Lucas @ StarkWare < ***@***.***> escribió:

…

put #272 <#272> and #270 <#270> in the same PR as this one — Reply to this email directly, view it on GitHub <#271 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIKSPDJKST4HODF4YTVKK3YROT3JAVCNFSM6AAAAABCTP4XPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRRGUYTINBSGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[delaaxe]

@LucasLvy done

[0xLucqs]

can you also change all the assert(x == y, 'xyz') into assert_eq!(x, y, "xyz"); you can use a regex for that

[delaaxe]

can you also change all the assert(x == y, 'xyz') into assert_eq!(x, y, "xyz"); you can use a regex for that

I would wait for snfoundry to be ready before doing it in library code because error message catching infra isn't fully implemented yet foundry-rs/starknet-foundry#1627

[delaaxe]

done as much as i could, it failed in many places (out of gas, formatter unimplemented, other weird errors)

[0xLucqs]

Let's not care about other tools, if someone wants to use it with foundry they'll use the old version

[delaaxe]

well we at argent would like to use the latest alexandria with foundry, but the assert! macros feel a bit too unstable to be shipped to mainnet