bug: array slice naming error and generic option #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-j-roberts
changed the title
b-j-roberts
force-pushed
the
bug/array_slices
branch
2 times, most recently
from
9a15f67
to
ee5bc9f
Compare
0xLucqs
approved these changes
Feb 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of array slices had a variable naming issue, where
lenandendseems to representendandlenrespectively. Confusion leaked into the function description as well.I also created a generic
array_slice.Pull Request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?