-
Notifications
You must be signed in to change notification settings - Fork 292
feat: Improve docker-compose performance #483
feat: Improve docker-compose performance #483
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
==========================================
+ Coverage 34.16% 34.61% +0.45%
==========================================
Files 63 63
Lines 6960 6930 -30
Branches 6960 6930 -30
==========================================
+ Hits 2378 2399 +21
+ Misses 3822 3763 -59
- Partials 760 768 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I'm excited for this one, docker-compose has been crashing on my Mac M1 |
Do you think we should create a custom base image to support |
20bfefb
to
7edc8c3
Compare
7edc8c3
to
3e907b2
Compare
I'll have to test some docker deploys with gh actions in my fork to refactor the docker files. In the meantime, we can merge this one as a temporary fix for running docker in Mac M1 @dbejarano820 after this is merged, please confirm that you can run the docker-compose commands on your Mac |
This PR contains some small improvements in the docker-compose performance.
Pull Request type
Feature
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
docker-compose
when not running it in amd64 architectures (tested in a Mac M1) due to usingparitytech/ci-linux
as the base containercargo build --release
will crash while updating the crates.io indexResolves: #NA
What is the new behavior?
git
instead oflibgit2
. We can do that by appending--config net.git-fetch-with-cli=true
to the build command, or add that configurations in the Cargo config fileDoes this introduce a breaking change?
No
Other information
This PR was opened as a draft for us to discuss if this is the best approach to go and ignore performance issues on aarch64 (such as Macs Mx and RPi), or if we should support docker on other architectures (replacing
paritytech/ci-linux
base image).