Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeePassXC 2.7.5 on macOS quits unexpectedly on exit #9423

Closed
rstewart-inl opened this issue May 15, 2023 · 17 comments · Fixed by #9620
Closed

KeePassXC 2.7.5 on macOS quits unexpectedly on exit #9423

rstewart-inl opened this issue May 15, 2023 · 17 comments · Fixed by #9620
Assignees
@droidmonkey
Labels
crash 💥 high priority 🚨 platform: macOS regression
Milestone
v2.7.6

Comments

@rstewart-inl
Copy link

Overview

Updated from 2.7.4 to 2.7.5 on an Intel Mac running macOS 13.3.1(a). Exiting KeePassXC causes Apples "KeePassXC quit unexpectedly" to pop up every time.

Diagnostics attached.
2023-0515-keepassxc-diagnostics.txt
@droidmonkey
Copy link
Member

This isn't crashing in keepassxc code. This looks like a qt bug.

@adudek16
Copy link

+1 for Monterey on Intel
Not seen on Big Sur (11.7.6 [Intel]) or Ventura (13.3.1 [M2])
Is QT installed as part of Keepassxc or OSX?
This is definitely tied to at least Monterey (12.6.5 [Intel]) as I do not see this on my Mac running Big Sur (11.7.6 [Intel]).

@rstewart-inl
Copy link
Author

@adudek16 Good point: I am also not seeing this behavior on Ventura @ 13.3.1(a) on M1

@droidmonkey
Copy link
Member

This is 100% a qt bug

@andreasgremm
Copy link

andreasgremm commented May 16, 2023 •
edited by droidmonkey
Loading

Hi,
I am seeing this as well.

It has not been seen with the 2.7.4 Version.
Is it possible to provide a Download-Link for the previous version?

Kind regards,
Andreas

@keepassxreboot keepassxreboot locked and limited conversation to collaborators May 16, 2023
@droidmonkey
Copy link
Member

The download page on our website has a link to previous releases.

@droidmonkey droidmonkey pinned this issue May 16, 2023
@NFM-8 NFM-8 mentioned this issue May 17, 2023
Closed
@aeroxx9 aeroxx9 mentioned this issue May 31, 2023
Closed
@droidmonkey
Copy link
Member

I'm starting to think this code addition might be the cause of the crash: #8615

Can anyone affected by this build a version of 2.7.5 without this code change to confirm?

@droidmonkey droidmonkey self-assigned this Jun 5, 2023
@droidmonkey droidmonkey added this to the v2.7.6 milestone Jun 5, 2023
@nobrowser nobrowser mentioned this issue Jun 7, 2023
Merged
@keepassxreboot keepassxreboot unlocked this conversation Jun 10, 2023
@baekelite
Copy link

Can confirm that a build of 2.7.5 without #8615 will not crash in this manner

@jowodo jowodo mentioned this issue Jun 21, 2023
Closed
@castevinz
Copy link

Still have the same issue since 2.7.5 on my mac intel with macos 12.6.3. Is any fix planned in 2.7.6 ?

@jakeeri jakeeri mentioned this issue Jun 28, 2023
Closed
@adudek16
Copy link

Since it does seem that this is NOT a QT issue, ICBW, will this be fixed in 2.7.6?

@droidmonkey
Copy link
Member

Yes.

@red-lonely-neuron
Copy link

Can anyone affected by this build a version of 2.7.5 without this code change to confirm?

Hi. I have cloned the repo, reverted that commit and rebuilt KeepassXC. I confirm It doesn't crash at exit.

@RajDotKapoor

This comment was marked as outdated.

Sign in to view
@keepassxreboot keepassxreboot locked and limited conversation to collaborators Jul 6, 2023
droidmonkey added a commit that referenced this issue Jul 9, 2023
@droidmonkey
MacOS: Fix crash on exit
e817c72 
* Fixes #9423
@droidmonkey droidmonkey mentioned this issue Jul 9, 2023
Merged
@droidmonkey
Copy link
Member

Hi. I have cloned the repo, reverted that commit and rebuilt KeepassXC. I confirm It doesn't crash at exit.

@red-lonely-neuron can you please test again using #9620

@keepassxreboot keepassxreboot unlocked this conversation Jul 9, 2023
@voiceactivity
Copy link

Same for me:

Translated Report (Full Report Below)

Process: KeePassXC [72076]
Path: /Applications/KeePassXC.app/Contents/MacOS/KeePassXC
Identifier: org.keepassxc.keepassxc
Version: 2.7.5 ()
Code Type: ARM-64 (Native)
Parent Process: launchd [1]
User ID: 501
Date/Time: 2023-07-13 17:08:06.4825 +1200
OS Version: macOS 13.4.1 (22F82)
Report Version: 12
Anonymous UUID: 456BDC8E-CA92-5933-BB47-8FF3A73FDFE4
...
System Integrity Protection: enabled
Crashed Thread: 0 Dispatch queue: com.apple.main-thread
Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x00002bdb2223c2c0
Exception Codes: 0x0000000000000001, 0x00002bdb2223c2c0
Termination Reason: Namespace SIGNAL, Code 11 Segmentation fault: 11
Terminating Process: exc handler [72076]
...
Thread 0 crashed with ARM Thread State (64-bit):
x0: 0x0000000000000000 x1: 0x00000001f5ebf117 x2: 0x00002bdb2223c2a0 x3: 0x0000000000000003
x4: 0x00005ffe930e16b0 x5: 0x0000000000000020 x6: 0x000000016f5eb3c8 x7: 0x0000000000000003
x8: 0x00000001f5ebf000 x9: 0x000000000000000a x10: 0x000000000000000a x11: 0x000000000000003f
x12: 0x000000000000002d x13: 0x000000013f0902c0 x14: 0x01000002015cd001 x15: 0x00000002015cd000
x16: 0x00000001a6247b70 x17: 0x00000002025d0f28 x18: 0x0000000000000000 x19: 0x00002bdb2223c2a0
x20: 0x0000000000000007 x21: 0x00000001f5ebf117 x22: 0x0000000000000000 x23: 0x000000016f5eac60
x24: 0x0000000000000000 x25: 0x000000016f5eace8 x26: 0x0000000200706000 x27: 0x000060000029d860
x28: 0x0000000000000000 fp: 0x000000016f5eac20 lr: 0xb5578001a6247b98
sp: 0x000000016f5eac00 pc: 0x00000001a6266ca4 cpsr: 0x20001000
far: 0x00002bdb2223c2c0 esr: 0x92000005 (Data Abort) byte read Translation fault

@red-lonely-neuron
Copy link

@red-lonely-neuron can you please test again using #9620

Hi.

I have run a test using the fix in #9620 and the application didn't crash. Here's how I tested:

  • I have checked out the 2.7.5 tag.
  • I have created a new test branch.
  • I have cherry-picked the commit e817c72 from the fix/macos-crash-exit branch.
  • I have cleanly configured the build, then I have built and run the application.

@keepassxreboot keepassxreboot locked and limited conversation to collaborators Jul 13, 2023
droidmonkey added a commit that referenced this issue Jul 13, 2023
@droidmonkey
MacOS: Fix crash on exit
9d72d8d 
* Fixes #9423
droidmonkey added a commit that referenced this issue Jul 15, 2023
@droidmonkey
MacOS: Fix crash on exit
1594e5f 
* Fixes #9423
@phoerious
Copy link
Member

2.7.6 is out.

@phoerious phoerious unpinned this issue Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@droidmonkey droidmonkey

Labels
crash 💥 high priority 🚨 platform: macOS regression
Projects
None yet
Milestone
v2.7.6
Development

Successfully merging a pull request may close this issue.

MacOS: Fix crash on exit keepassxreboot/keepassxc
10 participants
@phoerious @castevinz @voiceactivity @droidmonkey @RajDotKapoor @andreasgremm @adudek16 @red-lonely-neuron @rstewart-inl @baekelite