Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve get-alerts efficiency #698

Merged
merged 16 commits into from
Jan 11, 2024
Merged

Conversation

talboren
Copy link
Member

@talboren talboren commented Jan 8, 2024

No description provided.

@talboren talboren linked an issue Jan 8, 2024 that may be closed by this pull request
Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 8:03am

@talboren talboren changed the title feat(693): improve get alerts efficiency feat(get_alerts): improve efficiency Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (e1304fb) 66.70% compared to head (b2fddc7) 66.53%.

Files Patch % Lines
keep/api/core/db.py 16.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
- Coverage   66.70%   66.53%   -0.17%     
==========================================
  Files          49       49              
  Lines        2787     2797      +10     
==========================================
+ Hits         1859     1861       +2     
- Misses        928      936       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@talboren
Copy link
Member Author

@asharonbaltazar quite strangely toSorted and toReversed didn't work.

While Visual Studio Code might suggest its existence possibly due to an extension or a typing file, it's important to note that toSorted is not a standard method in JavaScript or TypeScript for array manipulation.

so I reverted the changes back.

@talboren talboren changed the title feat(get_alerts): improve efficiency chore: improve get-alerts efficiency Jan 11, 2024
@talboren talboren merged commit c840806 into main Jan 11, 2024
8 of 10 checks passed
@talboren talboren deleted the 693-improve-get_alerts-efficiency branch January 11, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve get_alerts efficiency
2 participants