Development #246
Development #246
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
src/main/java/org/roda_project/commons_ip2/cli/Validate.java|81 col 17| Variable 'cmd' should be declared final.
src/main/java/org/roda_project/commons_ip2/cli/Validate.java|82 col 12| Variable 'commandLineString' should be declared final.
src/main/java/org/roda_project/commons_ip2/cli/model/enums/ReportType.java|7 col 3| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/cli/model/enums/ReportType.java|7 col 29| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/cli/model/exception/handlers/PrintExceptionMessageHandler.java|15 col 3| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/cli/model/exception/handlers/ShortErrorMessageHandler.java|15 col 3| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/cli/Create.java|30 col 3| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/cli/Create.java|31 col 3| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/cli/Create.java|32 col 33| Variable 'spec' must be private and have accessor methods.
src/main/java/org/roda_project/commons_ip2/cli/Create.java|69| Line is longer than 120 characters (found 127).
src/main/java/org/roda_project/commons_ip2/cli/Create.java|98 col 17| Variable 'cmd' should be declared final.
src/main/java/org/roda_project/commons_ip2/cli/Create.java|99 col 12| Variable 'commandLineString' should be declared final.
src/main/resources/logback.xml|4 col 1| File contains tab characters (this is the first instance).
src/main/resources/schemas2/mets1_12.xjb|3 col 1| File contains tab characters (this is the first instance).
src/main/resources/schemas/mets1_11.xjb|3 col 1| File contains tab characters (this is the first instance).
| </schemaIncludes> | ||
| <cleanPackageDirectories>true</cleanPackageDirectories> | ||
| <generatePackage>org.roda_project.commons_ip.mets_v1_11.beans</generatePackage> | ||
| <generateDirectory>${project.build.directory}/generated-sources/xjc1</generateDirectory> |
There was a problem hiding this comment.
Line is longer than 120 characters (found 124).
| </schemaIncludes> | ||
| <cleanPackageDirectories>true</cleanPackageDirectories> | ||
| <generatePackage>org.roda_project.commons_ip2.mets_v1_12.beans</generatePackage> | ||
| <generateDirectory>${project.build.directory}/generated-sources/xjc2</generateDirectory> |
There was a problem hiding this comment.
Line is longer than 120 characters (found 124).
| </schemaIncludes> | ||
| <cleanPackageDirectories>true</cleanPackageDirectories> | ||
| <generatePackage>org.roda_project.commons_ip.mets_v1_11.beans</generatePackage> | ||
| <generateDirectory>${project.build.directory}/generated-sources/xjc1</generateDirectory> |
There was a problem hiding this comment.
Line is longer than 120 characters (found 124).
| </schemaIncludes> | ||
| <cleanPackageDirectories>true</cleanPackageDirectories> | ||
| <generatePackage>org.roda_project.commons_ip2.mets_v1_12.beans</generatePackage> | ||
| <generateDirectory>${project.build.directory}/generated-sources/xjc2</generateDirectory> |
There was a problem hiding this comment.
Line is longer than 120 characters (found 124).
| @@ -28,6 +26,8 @@ | |||
| import org.roda_project.commons_ip.utils.IPException; | |||
| import org.roda_project.commons_ip.utils.ZipEntryInfo; | |||
|
|
|||
| import javax.xml.datatype.XMLGregorianCalendar; | |||
There was a problem hiding this comment.
Wrong order for 'javax.xml.datatype.XMLGregorianCalendar' import.
|
|
||
| public static final String ISSUES_LINK = "https://github.com/keeps/commons-ip/issues"; | ||
|
|
||
| public static final String LOGGER_FILE = "commons-ip.log.txt"; |
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -412,7 +412,12 @@ protected ReporterDetails validateCSIP91(final MetsValidatorState metsValidatorS | |||
| final List<Object> admids = d.getADMID(); | |||
| if (admids != null && !admids.isEmpty()) { | |||
| for (Object o : admids) { | |||
| final String admid = ((MdSecType) o).getID(); | |||
| String admid; | |||
There was a problem hiding this comment.
Variable 'admid' should be declared final.
| @@ -29,6 +32,9 @@ | |||
| */ | |||
| @CommandLine.Command(name = "validate", showDefaultValues = true, description = "Validates E-ARK IP packages against the specification") | |||
| public class Validate implements Callable<Integer> { | |||
| private static final Logger LOGGER = LoggerFactory.getLogger(Validate.class); | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -29,6 +32,9 @@ | |||
| */ | |||
| @CommandLine.Command(name = "validate", showDefaultValues = true, description = "Validates E-ARK IP packages against the specification") | |||
| public class Validate implements Callable<Integer> { | |||
| private static final Logger LOGGER = LoggerFactory.getLogger(Validate.class); | |||
| @CommandLine.Spec | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -29,6 +32,9 @@ | |||
| */ | |||
| @CommandLine.Command(name = "validate", showDefaultValues = true, description = "Validates E-ARK IP packages against the specification") | |||
| public class Validate implements Callable<Integer> { | |||
| private static final Logger LOGGER = LoggerFactory.getLogger(Validate.class); | |||
| @CommandLine.Spec | |||
| CommandLine.Model.CommandSpec spec; | |||
There was a problem hiding this comment.
Variable 'spec' must be private and have accessor methods.
No description provided.