Fixed #250 #261
Fixed #250 #261
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -48,6 +48,7 @@ public abstract class IP implements IPInterface { | |||
| private List<IPFile> documentation; | |||
|
|
|||
| private Map<String, ZipEntryInfo> zipEntries; | |||
| private String checksumAlgorithm; | |||
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -150,8 +151,8 @@ public static void zip(Map<String, ZipEntryInfo> files, OutputStream out, SIP si | |||
| } | |||
|
|
|||
| LOGGER.debug("Done zipping file"); | |||
| String checksum = checksums.get(IPConstants.CHECKSUM_ALGORITHM); | |||
| String checksumType = IPConstants.CHECKSUM_ALGORITHM; | |||
| String checksum = checksums.get(sip.getChecksum()); | |||
There was a problem hiding this comment.
Variable 'checksum' should be declared final.
| String checksum = checksums.get(IPConstants.CHECKSUM_ALGORITHM); | ||
| String checksumType = IPConstants.CHECKSUM_ALGORITHM; | ||
| String checksum = checksums.get(sip.getChecksum()); | ||
| String checksumType = sip.getChecksum(); |
There was a problem hiding this comment.
Variable 'checksumType' should be declared final.
| @@ -69,7 +69,7 @@ public void prepareEntryforZipping() throws IPException { | |||
| if (!rootMETS && fileType != null) { | |||
| METSUtils.setFileBasicInformation(LOGGER, getFilePath(), fileType); | |||
|
|
|||
| String checksumType = IPConstants.CHECKSUM_ALGORITHM; | |||
| String checksumType = this.getChecksum(); | |||
There was a problem hiding this comment.
Variable 'checksumType' should be declared final.
No description provided.