All changes made for version 2.2.0 #285
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|2444 col 117| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|2648 col 115| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|2649 col 75| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|2752 col 118| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|2753 col 53| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|2754 col 61| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|2755 col 59| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|2756 col 65| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|2757 col 65| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|2931 col 83| The String "An xml:id identifier for " appears 2 times in the file.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|2931 col 111| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|2932 col 59| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|3029 col 118| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|3030 col 106| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|3503 col 112| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|3504 col 63| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|3537 col 111| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|3538 col 56| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|3605 col 7| The String "identifier must be unique within the XML-document." appears 3 times in the file.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|3675 col 7| The String "must be unique within the XML-document." appears 3 times in the file.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|4406 col 116| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|4407 col 78| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|4408 col 85| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|4409 col 113| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsCSIPspec.java|4410 col 76| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsSIPspec.java|513 col 119| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsSIPspec.java|644 col 117| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsSIPspec.java|710 col 116| '+' should be on a new line.
src/main/java/org/roda_project/commons_ip2/validator/constants/ConstantsSIPspec.java|873 col 118| '+' should be on a new line.
| + "name/ID of the package, i.e. the name of the package root folder. For a " | ||
| + "representation level METS document this value records the name/ID of the " | ||
| + "representation, i.e. the name of the top-level representation folder."; | ||
| public static final String VALIDATION_REPORT_SPECIFICATION_CSIP1_DESCRIPTION = "The mets/@OBJID attribute is mandatory, " |
There was a problem hiding this comment.
Line is longer than 120 characters (found 123).
| + "attribute is mandatory for representation level METS documents. The " | ||
| + "vocabulary will evolve under the care of the DILCIS Board as additional " | ||
| + "Content Information Type Specifications are developed."; | ||
| public static final String VALIDATION_REPORT_SPECIFICATION_CSIP4_DESCRIPTION = "Used to declare the Content " + |
There was a problem hiding this comment.
'+' should be on a new line.
| + "vocabulary will evolve under the care of the DILCIS Board as additional " | ||
| + "Content Information Type Specifications are developed."; | ||
| public static final String VALIDATION_REPORT_SPECIFICATION_CSIP4_DESCRIPTION = "Used to declare the Content " + | ||
| "Information Type Specification used when creating the package. " + |
There was a problem hiding this comment.
'+' should be on a new line.
| + "Content Information Type Specifications are developed."; | ||
| public static final String VALIDATION_REPORT_SPECIFICATION_CSIP4_DESCRIPTION = "Used to declare the Content " + | ||
| "Information Type Specification used when creating the package. " + | ||
| "Legal values are defined in a fixed vocabulary. The attribute " + |
There was a problem hiding this comment.
'+' should be on a new line.
| public static final String VALIDATION_REPORT_SPECIFICATION_CSIP4_DESCRIPTION = "Used to declare the Content " + | ||
| "Information Type Specification used when creating the package. " + | ||
| "Legal values are defined in a fixed vocabulary. The attribute " + | ||
| "is mandatory for representation level METS documents. The " + |
There was a problem hiding this comment.
'+' should be on a new line.
| public static final String VALIDATION_REPORT_SPECIFICATION_CSIP40_DESCRIPTION = "The IANA mime type " | ||
| + "for the referenced file."; | ||
| public static final String VALIDATION_REPORT_SPECIFICATION_CSIP40_DESCRIPTION = "The mime type of the referenced" + | ||
| " file.\n" + "It is a strong recommendation to use a qualified " + |
There was a problem hiding this comment.
'+' should be on a new line.
| + "for the referenced file."; | ||
| public static final String VALIDATION_REPORT_SPECIFICATION_CSIP40_DESCRIPTION = "The mime type of the referenced" + | ||
| " file.\n" + "It is a strong recommendation to use a qualified " + | ||
| "list like the IANA Media Type list.\n" + |
There was a problem hiding this comment.
'+' should be on a new line.
| public static final String VALIDATION_REPORT_SPECIFICATION_CSIP46_DESCRIPTION = "An xml:id identifier for the " | ||
| + "rights metadata section ( <rightsMD> ) " | ||
| + "used for internal package references. It must be unique within the package."; | ||
| public static final String VALIDATION_REPORT_SPECIFICATION_CSIP46_DESCRIPTION = "An xml:id identifier for the " + |
There was a problem hiding this comment.
'+' should be on a new line.
| + "rights metadata section ( <rightsMD> ) " | ||
| + "used for internal package references. It must be unique within the package."; | ||
| public static final String VALIDATION_REPORT_SPECIFICATION_CSIP46_DESCRIPTION = "An xml:id identifier for the " + | ||
| "rights metadata section (<rightsMD>) used for internal " + |
There was a problem hiding this comment.
'+' should be on a new line.
| @@ -2427,8 +2440,9 @@ private ConstantsCSIPspec() { | |||
| /** | |||
| * Constant specification description for id "CSIP53". | |||
| */ | |||
| public static final String VALIDATION_REPORT_SPECIFICATION_CSIP53_DESCRIPTION = "The IANA mime " | |||
| + "type for the referenced file."; | |||
| public static final String VALIDATION_REPORT_SPECIFICATION_CSIP53_DESCRIPTION = "The mime type of the " + | |||
There was a problem hiding this comment.
'+' should be on a new line.
No description provided.