Setup detekt

.github/dependabot.yml

@@ -0,0 +1,11 @@
+# To get started with Dependabot version updates, you'll need to specify which
+# package ecosystems to update and where the package manifests are located.
+# Please see the documentation for all configuration options:
+# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+
+version: 2
+updates:
+  - package-ecosystem: "gradle" # See documentation for possible values
+    directory: "/" # Location of package manifests
+    schedule:
+      interval: "weekly"

.github/workflows/ci.yml

@@ -7,12 +7,43 @@ on:
     branches: [ "main" ]
 
 jobs:
+  detekt:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/cache@v4
+        with:
+          path: |
+            ~/.gradle/caches
+            ~/.gradle/wrapper
+          key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
+          restore-keys: |
+            ${{ runner.os }}-gradle-
+      - name: Setup JDK 17
+        uses: actions/setup-java@v3
+        with:
+          java-version: '17'
+          distribution: 'temurin'
+      - name: Setup reviewdog
+        uses: reviewdog/action-setup@v1
+        with:
+          reviewdog_version: latest
+      - name: Grant execute permission for gradlew
+        run: chmod +x gradlew
+      - name: Detekt
+        run: ./gradlew detekt
+      - name: reviewdog report
+        if: failure()
+        env:
+          REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: cat ./build/reports/detekt/detekt.xml |
+          reviewdog -f=checkstyle -name="detekt" -reporter="github-pr-review"
   build:
+    needs: detekt
     runs-on: ubuntu-latest
-
     steps:
-    - uses: actions/checkout@v3
-    - uses: actions/cache@v3
+    - uses: actions/checkout@v4
+    - uses: actions/cache@v4
       with:
         path: |
           ~/.gradle/caches
@@ -24,7 +55,7 @@ jobs:
       uses: actions/setup-java@v4
       with:
         java-version: '17'
-        distribution: 'zulu'
+        distribution: 'temurin'
         cache: gradle
 
     - name: Grant execute permission for gradlew

app/src/main/java/dev/keiji/tlv/sample/ConstructedData.kt

@@ -1,6 +1,10 @@
 package dev.keiji.tlv.sample
 
-import dev.keiji.tlv.*
+import dev.keiji.tlv.BerTlv
+import dev.keiji.tlv.BerTlvItem
+import dev.keiji.tlv.BooleanTypeConverter
+import dev.keiji.tlv.ByteTypeConverter
+import dev.keiji.tlv.StringTypeConverter
 
 @BerTlv
 data class ConstructedData(

app/src/main/java/dev/keiji/tlv/sample/MainActivity.kt

@@ -8,4 +8,4 @@ class MainActivity : AppCompatActivity() {
         super.onCreate(savedInstanceState)
         setContentView(R.layout.activity_main)
     }
-}
+}

app/src/test/java/dev/keiji/tlv/sample/CompactPrimitiveDataTest.kt

@@ -1,6 +1,7 @@
 package dev.keiji.tlv.sample
 
-import org.junit.Assert.*
+import org.junit.Assert.assertArrayEquals
+import org.junit.Assert.fail
 import org.junit.Test
 import java.io.ByteArrayOutputStream
 import java.io.StreamCorruptedException

app/src/test/java/dev/keiji/tlv/sample/PrimitiveDataTest.kt

@@ -1,6 +1,8 @@
 package dev.keiji.tlv.sample
 
-import org.junit.Assert.*
+import org.junit.Assert.assertArrayEquals
+import org.junit.Assert.assertEquals
+import org.junit.Assert.fail
 import org.junit.Test
 import java.io.ByteArrayOutputStream
 import java.io.StreamCorruptedException

app/src/test/java/dev/keiji/tlv/sample/PrimitiveLengthLongFieldBytesSizeDataTest.kt

@@ -1,6 +1,7 @@
 package dev.keiji.tlv.sample
 
-import org.junit.Assert.*
+import org.junit.Assert.assertArrayEquals
+import org.junit.Assert.fail
 import org.junit.Test
 import java.io.ByteArrayOutputStream
 import java.io.StreamCorruptedException

build.gradle

@@ -1,9 +1,13 @@
+import io.gitlab.arturbosch.detekt.Detekt
+import io.gitlab.arturbosch.detekt.report.ReportMergeTask
+
 // Top-level build file where you can add configuration options common to all sub-projects/modules.
 plugins {
     id 'com.android.application' version '8.2.1' apply false
     id 'com.android.library' version '8.2.1' apply false
     id 'org.jetbrains.kotlin.android' version '1.9.22' apply false
     id 'org.jetbrains.kotlin.jvm' version '1.9.22' apply false
+    id("io.gitlab.arturbosch.detekt") version "1.23.5"
 }
 
 Properties sonaTypeProps = new Properties()
@@ -25,6 +29,27 @@ ext {
     repoUrl = versionCode.endsWith('-SNAPSHOT') ? snapshotsRepoUrl : releasesRepoUrl
 }
 
-task clean(type: Delete) {
+tasks.register('reportMerge', ReportMergeTask) {
+    output = layout.buildDirectory.file("reports/detekt/detekt.xml")
+}
+
+subprojects {
+    apply plugin: 'io.gitlab.arturbosch.detekt'
+
+    detekt {
+        buildUponDefaultConfig = true
+        allRules = true
+        config.setFrom("$rootDir/config/detekt/detekt.yml")
+        parallel = true
+    }
+
+    afterEvaluate { project ->
+        project.tasks.withType(Detekt) {
+            finalizedBy reportMerge
+        }
+    }
+}
+
+tasks.register('clean', Delete) {
     delete rootProject.buildDir
 }