Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sort husky hooks #103

Merged
merged 6 commits into from
Dec 30, 2019
Merged

feat: sort husky hooks #103

merged 6 commits into from
Dec 30, 2019

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Dec 20, 2019

Not sure is this #20 requested, we should sort them anyway.

index.js Outdated
Comment on lines 22 to 48
// https://git-scm.com/docs/githooks
[
'applypatch-msg',
'pre-applypatch',
'post-applypatch',
'pre-commit',
'pre-merge-commit',
'prepare-commit-msg',
'commit-msg',
'post-commit',
'pre-rebase',
'post-checkout',
'post-merge',
'pre-push',
'pre-receive',
'update',
'post-receive',
'post-update',
'push-to-checkout',
'pre-auto-gc',
'post-rewrite',
'rebase',
'sendemail-validate',
'fsmonitor-watchman',
'p4-pre-submit',
'post-index-change',
],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You prefer keep this list here, or a separate package I build https://github.com/fisker/git-hooks-list ?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I was thinking we could start moving a lot of this stuff out to dependencies. I'm happy to add this dependency 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@keithamus keithamus merged commit ddebf46 into keithamus:master Dec 30, 2019
@keithamus
Copy link
Owner

🎉 This PR is included in version 1.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fisker fisker deleted the sort-husky-hooks branch December 31, 2019 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants