Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Url Mangalek "ar" #1992

Merged
merged 2 commits into from
Mar 23, 2024
Merged

Update Url Mangalek "ar" #1992

merged 2 commits into from
Mar 23, 2024

Conversation

mohamedotaku
Copy link
Contributor

@mohamedotaku mohamedotaku commented Mar 20, 2024

Close #1936
Close #2032
Close #1999

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

@AwkwardPeak7
Copy link
Contributor

thoughts on this?

@mohamedotaku
Copy link
Contributor Author

thoughts on this?

If you check these sites, you will find that they face the same problem at the same time. If one of them goes out of service, they all go out of service, and if one of them changes his Url, they all change it. They are all copies of each other.

I still don't know what's right for them. Should they be collected in one extension and have a list of Urls so that the user can choose the sites he wants. Or just leave them divided into different extensions and add the option to change the Urls for the user.

@AwkwardPeak7
Copy link
Contributor

if you can provide all the different mirrors of mangalek, then it should be put in a single extension as mirrors.

@mohamedotaku
Copy link
Contributor Author

if you can provide all the different mirrors of mangalek, then it should be put in a single extension as mirrors.

It's easy for Mangalek. The problem is with other sites like Manga Stars and Manga Spark ... They are look like Mangalik and they have same problem of mangalik.

@mohamedotaku
Copy link
Contributor Author

@LoverFreedom
Copy link

if you can provide all the different mirrors of mangalek, then it should be put in a single extension as mirrors.

It's easy for Mangalek. The problem is with other sites like Manga Stars and Manga Spark ... They are look like Mangalik and they have same problem of mangalik.

And Mangalionz and Mangalink

Copy link
Contributor

@AwkwardPeak7 AwkwardPeak7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put the url in a constant val at top of file and use that here and in defaultBaseUrl;

also did you run this to make sure it works? since defaultBaseUrl wasn't updated

@AwkwardPeak7 AwkwardPeak7 merged commit fc1c835 into keiyoushi:main Mar 23, 2024
20 checks passed
@mohamedotaku mohamedotaku deleted the Mangalek branch March 23, 2024 10:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changed ulr of mangalek Update Mangalek URL MangaLek : Automatic link redirection
3 participants