Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixiv: fix search repeats itself #5149

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Conversation

lamaxama
Copy link
Contributor

Close #4923

PixivFilters is a delegation that acts as a proxy to MutableList. However, the hashcode is not proxied to MutableList. ref: https://youtrack.jetbrains.com/issue/KT-15445

Therefore, the hashcode of filters here is not the hashcode of the list, even if two filters have the same content.

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

@lamaxama lamaxama changed the title Fix pixiv Pixiv: fix search repeats itself Sep 21, 2024
@AwkwardPeak7 AwkwardPeak7 merged commit 68f1bc8 into keiyoushi:main Sep 22, 2024
23 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pixiv serach repeats itself
2 participants