Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix lastDate() value for intervals > 25 days #711

Merged
merged 2 commits into from
Oct 12, 2023
Merged

fix: fix lastDate() value for intervals > 25 days #711

merged 2 commits into from
Oct 12, 2023

Conversation

sheerlox
Copy link
Collaborator

@sheerlox sheerlox commented Oct 2, 2023 •
edited
Loading

Description

Update the internal lastExecution variable when running onTick, not when checking if we should run onTick or set a new timeout.

Related Issue

Fixes #710.

Motivation and Context

See related issue.

How Has This Been Tested?

Added test case. See the failing test workflow before pushing the fix.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • If my change introduces a breaking change, I have added a ! after the type/scope in the title (see the Conventional Commits standard).

@sheerlox sheerlox added the type:bug Bug reports and bug fixes label Oct 2, 2023
@sheerlox sheerlox marked this pull request as ready for review October 2, 2023 16:26
@sheerlox sheerlox requested a review from intcreator October 2, 2023 16:26
@sheerlox sheerlox mentioned this pull request Oct 3, 2023
Closed
@sheerlox sheerlox force-pushed the fix/710/last-execution-date branch from a7c33f8 to 8309b48 Compare October 11, 2023 13:10
@sheerlox sheerlox merged commit 141aa00 into kelektiv:main Oct 12, 2023
10 checks passed
@sheerlox sheerlox deleted the fix/710/last-execution-date branch October 12, 2023 22:35
ncb000gt pushed a commit that referenced this pull request Oct 12, 2023
@semantic-release-bot
Release v3.1.1 [skip ci]
b75c067 
## [3.1.1](v3.1.0...v3.1.1) (2023-10-12)

### 🐛 Bug Fixes

* fix lastDate() value for intervals > 25 days ([#711](#711)) ([141aa00](141aa00))
* fix object constructor typings & make OC generic type optional ([#712](#712)) ([6536084](6536084))

### 📚 Documentation

* **readme:** update nextDates documentation ([#702](#702)) ([1ad2e22](1ad2e22))
@ncb000gt
Copy link
Member

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intcreator intcreator intcreator approved these changes

Assignees
No one assigned
Labels
released type:bug Bug reports and bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lastDate() value for cron intervals > 25 days is sometimes wrong
3 participants
@sheerlox @ncb000gt @intcreator