fix: fix object constructor typings & make OC generic type optional #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheerlox
changed the title
intcreator
approved these changes
Oct 12, 2023
ncb000gt
pushed a commit
that referenced
this pull request
Oct 12, 2023
## [3.1.1](v3.1.0...v3.1.1) (2023-10-12) ### 🐛 Bug Fixes * fix lastDate() value for intervals > 25 days ([#711](#711)) ([141aa00](141aa00)) * fix object constructor typings & make OC generic type optional ([#712](#712)) ([6536084](6536084)) ### 📚 Documentation * **readme:** update nextDates documentation ([#702](#702)) ([1ad2e22](1ad2e22))
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the generic typings on the
CronJob.from()method were not up-to-date withCronJob's typings, this PR updates them.while working on this, I attributed a default to the
OCgeneric parameter to improve usage convenience (that was previously bugging out the TypeScript compiler type's inference).we might want to consider substituting the generic place since users will need to type
Cmore often thanOC, but that would imply releasing a new major version, so we can probably leave it as is for now since we can doCronJob<CronOnCompleteCommand, { key: 'value' }to type bothcontextandonComplete, orCronJob<null, { key: 'value' }to omitonComplete.Related Issue
Discord thread: "How to trigger onComplete?"
Motivation and Context
CronJob.from()methodOCgeneric type parameter could be optionalHow Has This Been Tested?
Types of changes
Checklist:
!after the type/scope in the title (see the Conventional Commits standard).