Unshadow device re-exports

[vmx]

In the device module, all public items from cl3::device are re-exported. They even show up as public in the documentation. Nonetheless they aren't actually public.

To reproduce this issue, try to import opencl3::device::CL_UUID_SIZE_KHR, you will get an error like:

error[E0603]: constant `CL_UUID_SIZE_KHR` is private
    --> src/device.rs:2209:30
     |
2209 |             opencl3::device::CL_UUID_SIZE_KHR,
     |                              ^^^^^^^^^^^^^^^^ private constant
     |
note: the constant `CL_UUID_SIZE_KHR` is defined here
    --> /home/vmx/src/pl/filecoin/upstream/opencl3/src/device.rs:45:23
     |
45   |     CL_LUID_SIZE_KHR, CL_UUID_SIZE_KHR,
     |                       ^^^^^^^^^^^^^^^^

The private imports at

opencl3/src/device.rs

Line 18 in d004f1c

use cl3::ext::{

shadow the previous public re-exports

opencl3/src/device.rs

Line 15 in d004f1c

pub use cl3::device::*;

As most of the private imports are a subset of the public re-exports, we can just import the missing ones, which in this case is only cl_device_feature_capabilities_intel.

In order verify the subset, you can copy the list of imports from cl3::ext and the cl3::device re-exports from opencl-sys into two fiels and run tr ',' '\n|awk '{$1=$1;print}'|sort on each of them and finally diff the results.

---

I've never been a fan of glob imports, but I wasn't aware of that limitation in Rust. rust-lang/rust#31337 and https://rust-lang.github.io/rfcs/1560-name-resolution.html touches those topics in case someone is interested in all the details.

---

This is a regression, in earlier versions of opencl3 opencl3::device::CL_UUID_SIZE_KHR. used to be public.

[kenba]

I've never been a fan of glob imports, but I wasn't aware of that limitation in Rust.

Normally I wouldn't use glob imports, but it made sense to me to import all the definitions from the cl3 device package,
I'm surprised that the cl3::ext imports hid them. Thank you for finding and fixing this issue.

[kenba]

@vmx this change has now been published in version 0.9.1 of the crate.

[vmx]

Thanks for the quick turn-around time, it fixes the issues I was seeing!