gcsl numbers (genshinsim#2239)

* fix arithmetic operations for float and int. fix parsing of "1-1" expression

* fix lint

* revert "1-1" fixing

pkg/gcs/op.go

@@ -71,19 +71,27 @@ func neq(l, r *number) *number {
 }
 
 func add(l, r *number) *number {
-	return &number{
-		ival:    l.ival + r.ival,
-		fval:    l.fval + r.fval,
+	n := &number{
 		isFloat: l.isFloat || r.isFloat,
 	}
+	if n.isFloat {
+		n.fval = ntof(l) + ntof(r)
+	} else {
+		n.ival = l.ival + r.ival
+	}
+	return n
 }
 
 func mul(l, r *number) *number {
-	return &number{
-		ival:    l.ival * r.ival,
-		fval:    l.fval * r.fval,
+	n := &number{
 		isFloat: l.isFloat || r.isFloat,
 	}
+	if n.isFloat {
+		n.fval = ntof(l) * ntof(r)
+	} else {
+		n.ival = l.ival * r.ival
+	}
+	return n
 }
 
 func div(l, r *number) *number {
@@ -99,9 +107,13 @@ func div(l, r *number) *number {
 }
 
 func sub(l, r *number) *number {
-	return &number{
-		ival:    l.ival - r.ival,
-		fval:    l.fval - r.fval,
+	n := &number{
 		isFloat: l.isFloat || r.isFloat,
 	}
+	if n.isFloat {
+		n.fval = ntof(l) - ntof(r)
+	} else {
+		n.ival = l.ival - r.ival
+	}
+	return n
 }

pkg/gcs/sysfunc.go

@@ -655,7 +655,7 @@ func (e *Eval) executeAction(c *ast.CallExpr, env *Env) (Obj, error) {
 		if v.Typ() != typNum {
 			return nil, fmt.Errorf("map params should evaluate to a number, got %v", v.Inspect())
 		}
-		params[k] = int(v.(*number).ival)
+		params[k] = int(ntof(v.(*number)))
 	}
 
 	charKey := keys.Char(char.ival)