Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pipenv usage according to semi-official best practices. #144

Merged
merged 1 commit into from
May 8, 2018

Conversation

timofurrer
Copy link
Collaborator

@kennethreitz Can you shed some light into this. If this is really how pipenv should be used in our case?

Closes #142

@vlcinsky
Copy link
Contributor

vlcinsky commented Apr 4, 2018

I am almost complete with my own "best practices" resolving usage of pipenv in python library projects. Will publish it soon (probably as pipenv issue) and link here.

maya is one big pipenv lesson for me lecturing me slice by slice.

@timofurrer
Copy link
Collaborator Author

Thanks for the write-up. I hope that will lead to a sane best practice guide. I'll definitely follow it there.
Let's keep this PR open until then.

@timofurrer timofurrer self-assigned this Apr 5, 2018
@timofurrer
Copy link
Collaborator Author

I'll merge this for now so we don't miss anything in install_requires. We can always change it again ;)

@timofurrer timofurrer merged commit d3ddb39 into master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants