Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hold on to callbacks until buffer is flushed #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timdp
Copy link

@timdp timdp commented Apr 25, 2017

This fixes #67 (I think).

@timdp
Copy link
Author

timdp commented Dec 5, 2017

Bump. 😉

@bcosma
Copy link

bcosma commented Jan 23, 2018

I tested your solutions and it works. I noticed that if the systems logs 2 messages, one after another, only the first one appears in Papertrail. After implemented your solution the second one comes too.
Thanks. Let's hope it is approved soon.

@timdp timdp force-pushed the call-log-callback branch from f538d0c to f2798f6 Compare January 3, 2019 10:43
@timdp
Copy link
Author

timdp commented Jan 3, 2019

Bump v2.

@ffxsam
Copy link
Collaborator

ffxsam commented Jan 3, 2019

@timdp I'll review a PR if you open it against the new v2 branch. We could use all the help we can get to get the new version working 100%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If writing to buffer, winston 'logging' event will never be emitted
3 participants