This repository has been archived by the owner on Jan 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 63 63
Branches 14 14
=====================================
Hits 63 63
Continue to review full report at Codecov.
|
kentcdodds
approved these changes
Dec 21, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
You're welcome! It's a pleasure to be able to contribute. |
This was referenced Dec 22, 2017
This was referenced Sep 6, 2024
This was referenced Sep 13, 2024
This was referenced Sep 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Changing constant regex creation.
Why: This causes issues on some versions of Node. Currently there are two issues opened for this.
How: Instead of using RegEx constructor, use RegEx literal. As the regex is constant there is no need to use the constructor.
Checklist:
This is causing issues for us as well. It's just a small change that will increase compatibility.
Current issues that should be fixed with this:
#159
#160
Any feedback is really appreciated!