Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support custom sorter #124

Merged
merged 1 commit into from
Feb 18, 2021
Merged

feat: support custom sorter #124

merged 1 commit into from
Feb 18, 2021

Conversation

tannerlinsley
Copy link
Contributor

Adds the ability to fully-control sorting

  • Documentation
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Feb 18, 2021 •
edited
Loading

Codecov Report

Merging #124 (f6d8a80) into main (d54584d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #124   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          163       163           
  Branches        38        39    +1     
=========================================
  Hits           163       163
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54584d...f6d8a80. Read the comment docs.

@tannerlinsley
Copy link
Contributor Author

Looks like some prettier functionality got carried away here? I’m not sure why that happened.

@tannerlinsley
Copy link
Contributor Author

Wow, no matter what I commit, all of those prettier changes still happen. Any tips here?

@tannerlinsley tannerlinsley force-pushed the feat-custom-sorter branch 2 times, most recently from 4afda9d to 39655d1 Compare February 18, 2021 17:45
@tannerlinsley
Copy link
Contributor Author

Alright, it took some rebasing, cherry picking the lines and committing with --no-verify to get this to behave.

kentcdodds
kentcdodds approved these changes Feb 18, 2021
View reviewed changes
Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coolio! Thanks for working through this weird tooling stuff. Sorry about that. Thanks for the feature!

@kentcdodds kentcdodds merged commit 9d8e7e9 into kentcdodds:main Feb 18, 2021
@kentcdodds
Copy link
Owner

@all-contributors please add @tannerlinsley for code and tests

@allcontributors allcontributors bot mentioned this pull request Feb 18, 2021
Merged
@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @tannerlinsley! 🎉

@github-actions
Copy link

🎉 This PR is included in version 6.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tannerlinsley @kentcdodds