Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement Show dots only when needed #3009

Closed
cbieser opened this issue Jul 27, 2017 · 8 comments
Closed

Reimplement Show dots only when needed #3009

cbieser opened this issue Jul 27, 2017 · 8 comments

Comments

@cbieser
Copy link
Contributor

cbieser commented Jul 27, 2017

In 1.6.0 Dots where only inserted if needed

  Slick.prototype.buildDots = function() {
    var _ = this,
      i,
      dot;

    if (_.options.dots === true && _.slideCount > _.options.slidesToShow) {
      _.$slider.addClass('slick-dotted');

Please reimplemet this or make it configurable.

Version 1.7.0

@leggomuhgreggo
Copy link
Collaborator

Cool, would you like to make a PR?

@stephenmcghee
Copy link

+1 Please re-implement this.

@cbieser
Copy link
Contributor Author

cbieser commented Aug 28, 2017

@see #3080

@leggomuhgreggo
Copy link
Collaborator

Merged into master. Thanks!

@yangkennyk
Copy link

dots seem to show when there is only 1 slide again in 1.8

@juliussveikauskas
Copy link

I found there is that logic in slick.js. But if I use slick.min.js it doesn't work. So if you need this feature you can try to use slick.js instead of slick.min.js.

@floriancapelle
Copy link

I'm having the same issue in 1.8.0 again.

somethumb added a commit to somethumb/slick that referenced this issue Oct 19, 2021
kenwheeler#3009

In fact it's not even needed because jsdelivr will create the min file itself
@octipus
Copy link

octipus commented Sep 15, 2022

I found there is that logic in slick.js. But if I use slick.min.js it doesn't work. So if you need this feature you can try to use slick.js instead of slick.min.js.

Thank you! This worked for me. I had to manually minifiy the .js file but that's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants