Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish the TODO list of classes/functions to type. #949

Closed
gabrieldemarmiesse opened this issue Feb 9, 2020 · 0 comments · Fixed by #1003
Closed

Finish the TODO list of classes/functions to type. #949

gabrieldemarmiesse opened this issue Feb 9, 2020 · 0 comments · Fixed by #1003
Labels
documentation good first issue Easy to solve. Beginner-friendly. pinned

Comments

@gabrieldemarmiesse
Copy link
Contributor

gabrieldemarmiesse commented Feb 9, 2020

We have a big todo list of classes/functions to type (add type hints, see PEP484 for more infos about type hints) and the docs: https://docs.python.org/3/library/typing.html

Functions of the list should be typed and for classes, only the contructor (__init__()) should be typed. No need to specify the return type of a __init__() because it's always None.

When you add types for a function/class, you can remove it from the TODO list in the same pull request.

Please make multiple small pull requests. Not a single big one :)

If you don't really understand what is asked:
We did the same procedure in tensorflow/addons here: tensorflow/addons#989 See this issue and look into the pull requests made.

You can always ask if you're wondering what to do. It's fairly easy and a good way to start contributing to autokeras!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation good first issue Easy to solve. Beginner-friendly. pinned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants