Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete typing #989

Closed
seanpmorgan opened this issue Jan 31, 2020 · 7 comments
Closed

Complete typing #989

seanpmorgan opened this issue Jan 31, 2020 · 7 comments
Labels
good first issue help wanted Needs help as a contribution style Related to repository's style

Comments

@seanpmorgan
Copy link
Member

Since python2 support was dropped we've begun typing TFA.

To do this gracefully we excluded several modules which were under active development so as to minimize impact on active PRs. We need to remove those modules from the exclusion list as they become no longer worked on and type them appropriately.

Exclusion list:
https://github.com/tensorflow/addons/blob/master/tools/ci_build/verify/check_typing_info.py#L27-L135

@seanpmorgan seanpmorgan added help wanted Needs help as a contribution style Related to repository's style good first issue labels Jan 31, 2020
@seanpmorgan
Copy link
Member Author

Big thank you to @autoih for many PRs working towards this.

@AakashKumarNain
Copy link
Member

We need to include this in the contribution guidelines.

This was referenced Jan 31, 2020
@AakashKumarNain
Copy link
Member

LGTM! Can we add a simple example as well? Like a class with the constructor signature only.

@gabrieldemarmiesse
Copy link
Member

For more info about all this:

I opened an issue in the tensorflow repository about the autograph bug:

tensorflow/tensorflow#36462

List of pull requests linked to this issue:
#894
#925
#928
#929
#931
#971
#972
#975
#978
#981
#995
#999
#1007
#1002
#1015
#1016
#1019

@gabrieldemarmiesse
Copy link
Member

Yay! It's finished! Big thanks to @autoih who worked extra hard on this!

If some people are interested, we want to do the same with autokeras! See the link just above.

@seanpmorgan
Copy link
Member Author

Thanks so much for the great contributions @autoih

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted Needs help as a contribution style Related to repository's style
Projects
None yet
Development

No branches or pull requests

3 participants